Opened 2 years ago

Last modified 6 days ago

#31475 new defect

1 internet doctest failing in src/sage/tests/cmdline.py - ore_algebra version

Reported by: slabbe Owned by:
Priority: major Milestone:
Component: doctest coverage Keywords:
Cc: slelievre, tmonteil, mkauers, mmezzarobba Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slabbe)

On Ubuntu 18.04, running SageMath version 9.3.beta8, Release Date: 2021-03-07, the command

sage -t --optional=sage,internet src/sage/tests/cmdline.py

gives

sage -t --warn-long 74.8 --random-seed=0 src/sage/tests/cmdline.py
**********************************************************************
File "src/sage/tests/cmdline.py", line 606, in sage.tests.cmdline.test_executable
Failed example:
    err  # optional - internet
Expected:
    ''
Got:
    '/home/slabbe/GitBox/sage/local/lib/python3.8/site-packages/sage/misc
/package.py:114: UserWarning: failed to fetch the version of 
pkg=\'ore_algebra\' at https://pypi.org/pypi/ore_algebra/json\n  
warnings.warn("failed to fetch the version of pkg={!r} at {}".format(pkg,
 url))\n'
**********************************************************************
1 item had failures:
   1 of 229 in sage.tests.cmdline.test_executable
    [228 tests, 1 failure, 28.69 s]
----------------------------------------------------------------------
sage -t --warn-long 74.8 --random-seed=0 src/sage/tests/cmdline.py  # 1 doctest failed
----------------------------------------------------------------------

The complete failing example block is:

        sage: (out, err, ret) = test_executable(["sage", "--optional"])  # optional - internet
        sage: out.find("database_cremona_ellcurve") >= 0  # optional - internet
        True
        sage: err  # optional - internet
        ''
        sage: ret  # optional - internet
        0

I can reproduce the problem as follows:

sage: from sage.tests.cmdline import test_executable                                                 
sage: (out, err, ret) = test_executable(["sage", "--optional"])                                      
sage: out.find("database_cremona_ellcurve") >= 0                                                     
True
sage: err                                                                                            
'/home/slabbe/GitBox/sage/local/lib/python3.8/site-packages/sage/misc
/package.py:114: UserWarning: failed to fetch the version of 
pkg=\'ore_algebra\' at https://pypi.org/pypi/ore_algebra/json\n  
warnings.warn("failed to fetch the version of pkg={!r} at {}".format(pkg, 
url))\n'

Change History (12)

comment:1 Changed 2 years ago by slabbe

Description: modified (diff)

comment:2 Changed 2 years ago by slabbe

Description: modified (diff)

comment:3 Changed 2 years ago by slabbe

Description: modified (diff)

comment:4 Changed 2 years ago by slabbe

Cc: slelievre added

Salut Samuel, ça ressemble à du code qu'on avait changé dans un autre ticket. Ça te dit quelque chose?

Last edited 2 years ago by slelievre (previous) (diff)

comment:5 Changed 2 years ago by mkoeppe

Cc: tmonteil added
Summary: 1 internet doctest failing in src/sage/tests/cmdline.py1 internet doctest failing in src/sage/tests/cmdline.py - ore_algebra version

This can be fixed by convincing the author of the ore_algebra package to make a proper release on PyPI and then updating build/pkgs/ore_algebra/requirements.txt

comment:6 in reply to:  5 Changed 2 years ago by tmonteil

Cc: mkauers mmezzarobba added

Replying to mkoeppe:

This can be fixed by convincing the author of the ore_algebra package to make a proper release on PyPI and then updating build/pkgs/ore_algebra/requirements.txt

Let me add them in CC.

We could also stop assuming that pip installed package come from PyPI, which offers more flexibility to downstream.

comment:7 Changed 23 months ago by mkoeppe

Milestone: sage-9.3sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

comment:8 Changed 18 months ago by mkoeppe

Milestone: sage-9.4sage-9.5

comment:9 Changed 14 months ago by mkoeppe

Milestone: sage-9.5sage-9.6

comment:10 Changed 9 months ago by mkoeppe

Milestone: sage-9.6sage-9.7

comment:11 Changed 5 months ago by mkoeppe

Milestone: sage-9.7sage-9.8

comment:12 Changed 6 days ago by mkoeppe

Milestone: sage-9.8
Note: See TracTickets for help on using tickets.