Opened 2 years ago

Closed 23 months ago

#31474 closed task (fixed)

Upgrade cysignals to 1.10.3

Reported by: embray Owned by:
Priority: major Milestone: sage-9.3
Component: packages: standard Keywords: cysignals
Cc: chapoton, fbissey, dimpase, mkoeppe, gh-kliem, gh-collares Merged in:
Authors: Erik Bray Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 81cab2b (Commits, GitHub, GitLab) Commit: 81cab2b2876facda33a0b84e714466efa3265b2f
Dependencies: Stopgaps:

Status badges

Description

Cysignals 1.10.3 includes a fix for #30945 and other minor bug fixes.

Before setting this ticket to positive review we need to make a final release of 1.10.3, but here is a ticket adding a beta release for testing.

Change History (18)

comment:1 Changed 2 years ago by embray

Authors: → Erik Bray
Branch: → u/embray/ticket-31474
Commit: → 79b0cfbb90faf5bbf97cdacd46cf6fbbf843d2db
Status: new → needs_review
Work issues: → release cysignals 1.10.3 final and update spkg version, checksums

New commits:

​79b0cfbTicket #31474: Upgrade Cysignals provisionally to 1.10.3b0 for testing.

comment:2 Changed 2 years ago by embray

Status: needs_review → needs_work

Building Sage against this is currently failing, likely due to ​https://github.com/sagemath/cysignals/pull/134

comment:3 in reply to:  2 Changed 2 years ago by gh-kliem

Replying to embray:

Building Sage against this is currently failing, likely due to ​https://github.com/sagemath/cysignals/pull/134

Yes, this is how I found out about it in the first place.

comment:4 Changed 2 years ago by gh-kliem

After patching with ​​https://github.com/sagemath/cysignals/pull/134 all tests pass on my side.

comment:5 in reply to:  4 Changed 2 years ago by embray

Replying to gh-kliem:

After patching with ​​https://github.com/sagemath/cysignals/pull/134 all tests pass on my side.

I'm testing it now too, but thanks for confirming! I'll make a release candidate after.

comment:6 Changed 2 years ago by git

Commit: 79b0cfbb90faf5bbf97cdacd46cf6fbbf843d2db → 8a80376f0ee7f282f920ebee8fb7e4ee10d41319

Branch pushed to git repo; I updated commit sha1. New commits:

​8a80376Update cysignals to 1.10.3rc0

comment:7 Changed 2 years ago by embray

Cc: gh-kliem added
Status: needs_work → needs_review

comment:8 Changed 2 years ago by gh-kliem

Reviewers: → https://github.com/kliem/sage/pull/40

comment:9 Changed 2 years ago by gh-kliem

Reviewers: https://github.com/kliem/sage/pull/40 → https://github.com/kliem/sage/pull/40/checks

Testing this on top of #31245.

comment:10 Changed 23 months ago by embray

Sage builds for me with this and all the tests pass except for the orthogonal one fixed at #26912.

comment:11 Changed 23 months ago by gh-collares

Cc: gh-collares added

comment:12 Changed 23 months ago by gh-kliem

Reviewers: https://github.com/kliem/sage/pull/40/checks → Jonathan Kliem

This looks good to me modulo the actual release.

comment:13 Changed 23 months ago by embray

Ok, I'll make the final release then. It will be unchanged from the release candidate other than some CI fixes I made (which don't change the code).

comment:14 Changed 23 months ago by git

Commit: 8a80376f0ee7f282f920ebee8fb7e4ee10d41319 → 81cab2b2876facda33a0b84e714466efa3265b2f

Branch pushed to git repo; I updated commit sha1. New commits:

​81cab2bUpdate cysignals to 1.10.3.

comment:15 Changed 23 months ago by embray

Status: needs_review → positive_review

Ok then, this should be good to go.

comment:16 Changed 23 months ago by embray

Work issues: release cysignals 1.10.3 final and update spkg version, checksums

comment:17 Changed 23 months ago by gh-kliem

Thank you for this release.

comment:18 Changed 23 months ago by vbraun

Branch: u/embray/ticket-31474 → 81cab2b2876facda33a0b84e714466efa3265b2f
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.