#31419 closed enhancement (fixed)

Update python to 3.9.2

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: packages: standard Keywords: upgrade, python
Cc: fbissey, arojas, slelievre Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 5e810dd (Commits, GitHub, GitLab) Commit: 5e810dd712cb9a67007df6f37f4164af95da3ce6
Dependencies: Stopgaps:

Status badges

Change History (12)

comment:1 Changed 11 months ago by mkoeppe

  • Branch set to u/mkoeppe/update_python_to_3_9_2

comment:2 Changed 11 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 5e810dd712cb9a67007df6f37f4164af95da3ce6
  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/584627033
  • Status changed from new to needs_review

New commits:

5e810ddbuild/pkgs/python3: Update to 3.9.2

comment:3 Changed 11 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/584627033 to https://github.com/mkoeppe/sage/actions/runs/584631860

comment:4 Changed 11 months ago by mkoeppe

  • Cc fbissey arojas added
  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/584631860 to https://github.com/mkoeppe/sage/actions/runs/584631860, ...

comment:5 Changed 11 months ago by slelievre

Any way to base this on top of #31344?

Last edited 11 months ago by slelievre (previous) (diff)

comment:6 follow-up: Changed 11 months ago by mkoeppe

Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344 and then merge it in, using git merge FETCH_HEAD.

comment:7 in reply to: ↑ 6 ; follow-ups: Changed 11 months ago by slelievre

  • Cc slelievre added
  • Keywords upgrade python added

Replying to mkoeppe:

Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344 and then merge it in, using git merge FETCH_HEAD.

I tested as follows.

Set up a new clone with tricks to save time and bandwidth:

$ ORIG=sage.git  # local mirror of https://github.com/sagemath/sage.git
$ DEST=sage93c  # name for new clone
$ UPST=$(pwd)/sage-upstream  # common upstream folder for several clones
$ git clone --single-branch --branch develop --tags $ORIG $DEST  # clone locally
$ cd $DEST
$ ln -s $UPST ./upstream  # use common upstream folder to download less 
$ git remote add trac git://trac.sagemath.org/sage.git -t develop

Follow your advice:

$ git trac checkout 31419
$ git trac fetch 31344
$ git merge FETCH_HEAD

Build and test:

$ source .homebrew-build-env
$ ./bootstrap -q
$ ./configure --enable-download-from-upstream-url -q
$ make -s V=0
$ make -s V=0 testlong

The build succeeds but make testlong gives:

----------------------------------------------------------------------
sage -t --long src/sage/interfaces/singular.py  # Killed due to segmentation fault
sage -t --long src/sage/interfaces/mwrank.py  # 4 doctests failed
sage -t --long src/sage/interfaces/gap.py  # 7 doctests failed
----------------------------------------------------------------------

When run again separately (with ./sage -t --long), the tests

  • pass for src/sage/interfaces/singular.py and src/sage/interfaces/mwrank.py
  • keep failing for src/sage/interfaces/gap.py

comment:8 in reply to: ↑ 7 Changed 11 months ago by mkoeppe

I don't think these doctest failures are related to this update

comment:9 in reply to: ↑ 7 Changed 11 months ago by mkoeppe

Replying to slelievre:

I tested as follows.

Set up a new clone with tricks to save time and bandwidth:

$ ORIG=sage.git  # local mirror of https://github.com/sagemath/sage.git
$ DEST=sage93c  # name for new clone
...
$ git clone --single-branch --branch develop --tags $ORIG $DEST  # clone locally

Even easier is to use (cd $ORIG && git worktree add $DEST)

comment:10 Changed 11 months ago by dimpase

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/584631860, ... to Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:11 Changed 11 months ago by mkoeppe

Thanks!

comment:12 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/update_python_to_3_9_2 to 5e810dd712cb9a67007df6f37f4164af95da3ce6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.