Opened 22 months ago
Closed 21 months ago
#31419 closed enhancement (fixed)
Update python to 3.9.2
Reported by: | Matthias Köppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | packages: standard | Keywords: | upgrade, python |
Cc: | François Bissey, Antonio Rojas, Samuel Lelièvre | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 5e810dd (Commits, GitHub, GitLab) | Commit: | 5e810dd712cb9a67007df6f37f4164af95da3ce6 |
Dependencies: | Stopgaps: |
Change History (12)
comment:1 Changed 22 months ago by
Branch: | → u/mkoeppe/update_python_to_3_9_2 |
---|
comment:2 Changed 22 months ago by
Authors: | → Matthias Koeppe |
---|---|
Commit: | → 5e810dd712cb9a67007df6f37f4164af95da3ce6 |
Reviewers: | → https://github.com/mkoeppe/sage/actions/runs/584627033 |
Status: | new → needs_review |
comment:3 Changed 22 months ago by
Reviewers: | https://github.com/mkoeppe/sage/actions/runs/584627033 → https://github.com/mkoeppe/sage/actions/runs/584631860 |
---|
comment:4 Changed 22 months ago by
Cc: | François Bissey Antonio Rojas added |
---|---|
Reviewers: | https://github.com/mkoeppe/sage/actions/runs/584631860 → https://github.com/mkoeppe/sage/actions/runs/584631860, ... |
comment:6 follow-up: 7 Changed 21 months ago by
Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344
and then merge it in, using git merge FETCH_HEAD
.
comment:7 follow-ups: 8 9 Changed 21 months ago by
Cc: | Samuel Lelièvre added |
---|---|
Keywords: | upgrade python added |
Replying to mkoeppe:
Samuel, to test, you can just fetch the branch of that ticket using
git trac fetch 31344
and then merge it in, usinggit merge FETCH_HEAD
.
I tested as follows.
Set up a new clone with tricks to save time and bandwidth:
$ ORIG=sage.git # local mirror of https://github.com/sagemath/sage.git $ DEST=sage93c # name for new clone $ UPST=$(pwd)/sage-upstream # common upstream folder for several clones $ git clone --single-branch --branch develop --tags $ORIG $DEST # clone locally $ cd $DEST $ ln -s $UPST ./upstream # use common upstream folder to download less $ git remote add trac git://trac.sagemath.org/sage.git -t develop
Follow your advice:
$ git trac checkout 31419 $ git trac fetch 31344 $ git merge FETCH_HEAD
Build and test:
$ source .homebrew-build-env $ ./bootstrap -q $ ./configure --enable-download-from-upstream-url -q $ make -s V=0 $ make -s V=0 testlong
The build succeeds but make testlong
gives:
---------------------------------------------------------------------- sage -t --long src/sage/interfaces/singular.py # Killed due to segmentation fault sage -t --long src/sage/interfaces/mwrank.py # 4 doctests failed sage -t --long src/sage/interfaces/gap.py # 7 doctests failed ----------------------------------------------------------------------
When run again separately (with ./sage -t --long
), the tests
- pass for
src/sage/interfaces/singular.py
andsrc/sage/interfaces/mwrank.py
- keep failing for
src/sage/interfaces/gap.py
comment:9 Changed 21 months ago by
Replying to slelievre:
I tested as follows.
Set up a new clone with tricks to save time and bandwidth:
$ ORIG=sage.git # local mirror of https://github.com/sagemath/sage.git $ DEST=sage93c # name for new clone ... $ git clone --single-branch --branch develop --tags $ORIG $DEST # clone locally
Even easier is to use (cd $ORIG && git worktree add $DEST)
comment:10 Changed 21 months ago by
Reviewers: | https://github.com/mkoeppe/sage/actions/runs/584631860, ... → Dima Pasechnik |
---|---|
Status: | needs_review → positive_review |
all good in view of https://github.com/mkoeppe/sage/actions/runs/584631860
comment:12 Changed 21 months ago by
Branch: | u/mkoeppe/update_python_to_3_9_2 → 5e810dd712cb9a67007df6f37f4164af95da3ce6 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
New commits:
build/pkgs/python3: Update to 3.9.2