Changes between Initial Version and Version 2 of Ticket #31404


Ignore:
Timestamp:
02/16/21 12:37:52 (10 months ago)
Author:
embray
Comment:

If eventually approved, this would supersede #31297.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31404

    • Property Status changed from new to needs_review
    • Property Commit changed from to 943b009d917673aa833c3ec67922cbedfbc3fe33
    • Property Branch changed from to u/embray/gappy-without-wrappers
  • Ticket #31404 – Description

    initial v2  
    11This is a follow-up to #31297, particularly inspired by ticket:31297#comment:17.  It is a more disruptive change, in that instead of providing wrappers around gappy that are Sage Parents and Elements, it follows the example of cypari2 and just uses gappy more-or-less directly without any wrappers.
    22
    3 It remains completely agnostic to the coercion system, though I am not completely happy with this state of affairs.  In particular you can see I had to add a special case to `Polynomial.__call__` for handling evaluating polynomials on GapObjs, a case that used to work fine, but now needs a special case since other Sage types cannot be coerced to GapObjs.
     3It remains completely agnostic to the coercion system, though I am not completely happy with this state of affairs.  In particular you can see I had to add a special case to `Polynomial.__call__` for handling evaluating polynomials on `GapObj`s, a case that used to work fine, but now needs a special case since other Sage types cannot be coerced to `GapObj`s.
    44
    55Also had to add special cases for instantiating Integers and Rationals from GapObjs, but on the plus side this is now a bit faster.