Opened 17 months ago
Last modified 3 months ago
#31399 needs_info enhancement
mod function for DynamicalSystem
Reported by: | gh-Saher-Amasha | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-9.7 |
Component: | dynamics | Keywords: | |
Cc: | bhutz | Merged in: | |
Authors: | Reviewers: | Saher Amasha,Safa Amasha | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/gh-Saher-Amasha/mod_function_for_dynamicalsystem (Commits, GitHub, GitLab) | Commit: | f453ffd0ab6c05e925c597bf266afa315119bf10 |
Dependencies: | Stopgaps: |
Description (last modified by )
mod function for Dynamical Systems, the function takes as a parameter a prime p and returns the Dynamical System modulo p
Change History (15)
comment:1 Changed 17 months ago by
- Description modified (diff)
comment:2 Changed 16 months ago by
- Status changed from new to needs_review
comment:3 Changed 16 months ago by
- Status changed from needs_review to positive_review
comment:4 follow-up: ↓ 6 Changed 16 months ago by
- Milestone changed from sage-9.3 to sage-duplicate/invalid/wontfix
comment:5 Changed 16 months ago by
- Milestone changed from sage-duplicate/invalid/wontfix to sage-9.4
- Status changed from positive_review to needs_review
comment:6 in reply to: ↑ 4 Changed 16 months ago by
Replying to chapoton:
assumed to be invalid. Otherwise, no self-review is allowed.
did a commit and changed it from new to needs review however I had a problem with my internet and my commit didn't go through so i changed it from needs review to positive review by mistake sorry about that
comment:7 Changed 16 months ago by
- Branch set to u/gh-Saher-Amasha/mod_function_for_dynamicalsystem
comment:8 Changed 14 months ago by
- Commit set to 00a32f28163053468654cdd5ffc62a579e401dfc
See my comments on #31464, which I've just marked as depending on this ticket (since the branch there includes the changes in this ticket). Ideally, you'll update this ticket with the suggestions that are relevant to the mod
method, then once that's reviewed you can merge the updated version into your branch for #31464.
New commits:
00a32f2 | mod function for Dynamical Systems, the function takes as a parameter a prime p and returns the Dynamical System modulo p
|
comment:9 Changed 14 months ago by
- Status changed from needs_review to needs_work
comment:10 Changed 13 months ago by
- Commit changed from 00a32f28163053468654cdd5ffc62a579e401dfc to f453ffd0ab6c05e925c597bf266afa315119bf10
Branch pushed to git repo; I updated commit sha1. New commits:
f453ffd | fixed style issues
|
comment:11 Changed 13 months ago by
- Status changed from needs_work to needs_review
comment:12 Changed 11 months ago by
- Milestone changed from sage-9.4 to sage-9.5
Setting a new milestone for this ticket based on a cursory review.
comment:13 Changed 11 months ago by
- Cc bhutz added
- Component changed from algebra to dynamics
- Status changed from needs_review to needs_info
This seems like an extension of the change_ring
functionality. We can achieve the same result with change_ring
as follows:
sage: R.<t> = GF(5)[] sage: I = R.ideal(t + 1) sage: k = ResidueField(I) sage: F.<t> = FractionField(R) sage: P.<x,y> = ProjectiveSpace(F, 1) sage: f = DynamicalSystem([x^2 + t*y^2, y^2]) sage: f.change_ring(k).change_ring(GF(5))
Is there a specific use case where change_ring
isn't sufficient?
comment:14 Changed 6 months ago by
- Milestone changed from sage-9.5 to sage-9.6
Stalled in needs_review
or needs_info
; likely won't make it into Sage 9.5.
comment:15 Changed 3 months ago by
- Milestone changed from sage-9.6 to sage-9.7
assumed to be invalid. Otherwise, no self-review is allowed.