#31398 closed defect (fixed)

building the pdf docs - undefined references

Reported by: strogdon Owned by:
Priority: major Milestone: sage-9.3
Component: documentation Keywords:
Cc: Merged in:
Authors: Steven Trogdon Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 44f14eb (Commits, GitHub, GitLab) Commit: 44f14ebbf202b6feba6aceb29c0202fdd4e7cc5c
Dependencies: Stopgaps:

Status badges

Description (last modified by strogdon)

In addressing multiply defined references in #31387 it was discovered that the following references were undefined:

$ grep -r "LaTeX Warning: Citation" local/share/doc/sage/latex/
local/share/doc/sage/latex/en/reference/coding/coding.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/matrices/hadamard_
local/share/doc/sage/latex/en/reference/algebras/algebras.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/sf/macdonald:macdo
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:cp1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/designs/database:designhandb
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/arithmetic_curves/arithmetic_curves.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/dyck_word:cha2005'
local/share/doc/sage/latex/en/reference/categories/categories.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/root_system/hecke

If when building the pdf docs you see

Chapter 8.
! TeX capacity exceeded, sorry [input stack size=5000].
\non@alpherr #1->\@latex@error {\string #1
                                          allowed only in math mode}\@ehd 
l.2922 ...Samplers for \protect\(\ZZ[x]\protect\)}

see #31397 for a work-around.

Change History (16)

comment:1 Changed 17 months ago by strogdon

  • Branch set to u/strogdon/trac_31398

comment:2 Changed 17 months ago by strogdon

  • Commit set to 7d0bd1cb9b98440cd3ea80e587a4604769a867e1
  • Description modified (diff)

New commits:

7d0bd1ccorrecting undefined references when building the pdf docs

comment:3 Changed 17 months ago by strogdon

  • Authors set to Steven Trogdon
  • Status changed from new to needs_review

The references added to src/doc/en/reference/references/index.rst sometime appear in other places in the sage source code under src/sage. I have left these reference in place. They may need to be removed. Additionally, there are other references in code under src/sage that are never referenced anywhere. These references may need to be addressed in another ticket.

comment:4 Changed 17 months ago by jhpalmieri

I think the duplicate references do need to be removed — we can get errors otherwise. We should also put the references into the standard format ("BH2012" instead of "BH12", for example).

comment:5 Changed 17 months ago by jhpalmieri

  • Branch changed from u/strogdon/trac_31398 to u/jhpalmieri/trac_31398

comment:6 Changed 17 months ago by jhpalmieri

  • Commit changed from 7d0bd1cb9b98440cd3ea80e587a4604769a867e1 to 6fc1f5d2951d924abc8fc14f13b4b53eba2b3cdf

The combinat directory wasn't fixed up when we switched from local references to a master reference file (I ran out of energy). So it's not surprising that there are problems coming from combinat.


New commits:

6fc1f5dtrac 31398: some clean up

comment:7 follow-up: Changed 17 months ago by jhpalmieri

  • Reviewers set to John Palmieri

I'm happy with your changes, so feel free to set a positive review on my behalf if you approve mine.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 17 months ago by strogdon

Replying to jhpalmieri:

I'm happy with your changes, so feel free to set a positive review on my behalf if you approve mine.

I'm glad you knew what to do with the repeated references. There are several labels that I believe should be changed. These are tough to spot. "CP16" should be "CP2016", "WW72" should be "WW1972", "SWW72" should be "SWW1972" and "Sz69" should be "Sz1969". I may have missed some.

comment:9 Changed 17 months ago by strogdon

  • Branch changed from u/jhpalmieri/trac_31398 to u/strogdon/trac_31398

comment:10 in reply to: ↑ 8 Changed 17 months ago by strogdon

  • Commit changed from 6fc1f5d2951d924abc8fc14f13b4b53eba2b3cdf to 44f14ebbf202b6feba6aceb29c0202fdd4e7cc5c

Replying to strogdon:

Replying to jhpalmieri:

I'm happy with your changes, so feel free to set a positive review on my behalf if you approve mine.

I'm glad you knew what to do with the repeated references. There are several labels that I believe should be changed. These are tough to spot. "CP16" should be "CP2016", "WW72" should be "WW1972", "SWW72" should be "SWW1972" and "Sz69" should be "Sz1969". I may have missed some.

I may be wrong. Perhaps some of these changed labels should not be placed in the master index. I'm not sure what the criteria is? I noticed that there are numerous references in local/share/doc/sage/pdf/en/reference/combinat/combinat.pdf. The existing changes allow the pdf docs to build without complaint. I don't know if leaving some of them in there original location would have produced the same result.


New commits:

44f14ebAdditional label modifications

comment:11 Changed 17 months ago by jhpalmieri

All of the references should be moved to the master index, and they all should be put into the standard format, but there are a lot of them in combinat, and it's tedious work. It can also yield a patch bomb. Fixing a few as we come across them is a good compromise.

Last edited 17 months ago by jhpalmieri (previous) (diff)

comment:12 Changed 17 months ago by jhpalmieri

See also #27497 and #28445.

comment:13 Changed 17 months ago by strogdon

I don't want to go overboard at this point. The initial motivation was to correctundefined references and nothing more. I will demure to you as to whether things are consistent with that desire. Your help is appreciated.

Version 0, edited 17 months ago by strogdon (next)

comment:14 Changed 17 months ago by jhpalmieri

I agree, no need to do more right now.

comment:15 Changed 17 months ago by jhpalmieri

  • Status changed from needs_review to positive_review

comment:16 Changed 16 months ago by vbraun

  • Branch changed from u/strogdon/trac_31398 to 44f14ebbf202b6feba6aceb29c0202fdd4e7cc5c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.