building the pdf docs - undefined references

[strogdon]

In addressing multiply defined references in #31387 it was discovered that the following references were undefined:

$ grep -r "LaTeX Warning: Citation" local/share/doc/sage/latex/
local/share/doc/sage/latex/en/reference/coding/coding.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/matrices/hadamard_
local/share/doc/sage/latex/en/reference/algebras/algebras.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/sf/macdonald:macdo
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:cp1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/designs/database:designhandb
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/graphs/graphs.log:LaTeX Warning: Citation `../combinat/sage/combinat/matrices/hadamard_matrix:bh1
local/share/doc/sage/latex/en/reference/arithmetic_curves/arithmetic_curves.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/dyck_word:cha2005'
local/share/doc/sage/latex/en/reference/categories/categories.log:LaTeX Warning: Citation `../graphs/../combinat/sage/combinat/root_system/hecke

If when building the pdf docs you see

Chapter 8.
! TeX capacity exceeded, sorry [input stack size=5000].
\non@alpherr #1->\@latex@error {\string #1
                                          allowed only in math mode}\@ehd 
l.2922 ...Samplers for \protect\(\ZZ[x]\protect\)}

see #31397 for a work-around.

[strogdon]

New commits:

​7d0bd1c

correcting undefined references when building the pdf docs

[strogdon]

The references added to src/doc/en/reference/references/index.rst sometime appear in other places in the sage source code under src/sage. I have left these reference in place. They may need to be removed. Additionally, there are other references in code under src/sage that are never referenced anywhere. These references may need to be addressed in another ticket.

[jhpalmieri]

I think the duplicate references do need to be removed — we can get errors otherwise. We should also put the references into the standard format ("BH2012" instead of "BH12", for example).

[jhpalmieri]

The combinat directory wasn't fixed up when we switched from local references to a master reference file (I ran out of energy). So it's not surprising that there are problems coming from combinat.

---

New commits:

​6fc1f5d

trac 31398: some clean up

[jhpalmieri]

I'm happy with your changes, so feel free to set a positive review on my behalf if you approve mine.

[strogdon]

Replying to jhpalmieri:

I'm happy with your changes, so feel free to set a positive review on my behalf if you approve mine.

I'm glad you knew what to do with the repeated references. There are several labels that I believe should be changed. These are tough to spot. "CP16" should be "CP2016", "WW72" should be "WW1972", "SWW72" should be "SWW1972" and "Sz69" should be "Sz1969". I may have missed some.

[strogdon]

Replying to strogdon:

Replying to jhpalmieri:

I'm happy with your changes, so feel free to set a positive review on my behalf if you approve mine.

I'm glad you knew what to do with the repeated references. There are several labels that I believe should be changed. These are tough to spot. "CP16" should be "CP2016", "WW72" should be "WW1972", "SWW72" should be "SWW1972" and "Sz69" should be "Sz1969". I may have missed some.

I may be wrong. Perhaps some of these changed labels should not be placed in the master index. I'm not sure what the criteria is? I noticed that there are numerous references in local/share/doc/sage/pdf/en/reference/combinat/combinat.pdf. The existing changes allow the pdf docs to build without complaint. I don't know if leaving some of them in there original location would have produced the same result.

---

New commits:

​44f14eb

Additional label modifications

[jhpalmieri]

All of the references should be moved to the master index, and they all should be put into the standard format, but there are a lot of them in combinat, and it's tedious work. It can also yield a patch bomb. Fixing a few as we come across them is a good compromise.

[jhpalmieri]

See also #27497 and #28445.

[strogdon]

I don't want to go overboard at this point. The initial motivation was to correctundefined references and nothing more. I will demur to you as to whether things are consistent with that desire. Your help is appreciated.

[jhpalmieri]

I agree, no need to do more right now.