Opened 13 years ago

Closed 13 years ago

#3138 closed task (fixed)

[with patch, positive review] Singular multivariate polynomial ring has redundant _repr_ method

Reported by: broune Owned by: broune
Priority: trivial Milestone: sage-3.0.2
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

MPolynomialRing_libsingular in sage/rings/polynomial/multi_polynomial_libsingular.pyx defines a _repr_ method which does the same thing as the _repr_ method that it inherits from MPolynomialRing_generic in sage/rings/polynomial/multi_polynomial_ring_generic.pyx

Thus the _repr_ method is redundant and should be removed.

Attachments (1)

no_singular_repr.changeset​ (1.1 KB) - added by broune 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by broune

comment:1 Changed 13 years ago by broune

  • Status changed from new to assigned

comment:2 Changed 13 years ago by malb

  • Summary changed from [with patch, needs review] Singular multivariate polynomial ring has redundant _repr_ method to [with patch, positive review] Singular multivariate polynomial ring has redundant _repr_ method

Yep, I wrote the libsingular version before the generic one. Positive review.

comment:3 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.0.2.alpha0

Note: See TracTickets for help on using tickets.