Opened 2 years ago
Closed 23 months ago
#31374 closed defect (fixed)
Fix an if statement that is never called in normal_form
| Reported by: | sbrandhorst | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-9.3 |
| Component: | quadratic forms | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Simon Brandhorst | Reviewers: | Frédéric Chapoton |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 7d304d6 (Commits, GitHub, GitLab) | Commit: | 7d304d69f42b7ae930f8c91ab298e52427f0c24d |
| Dependencies: | Stopgaps: |
Status badges
Description
In line 1483 in sage.quadratic_forms.genera.normal_form we have
b = [[0,5], [2,7], [1,2], [0,3], [0,1,5], [1,2,7], [0,3,7], [0,1,3]]
if x in b:
w = W[-1]
if x == [3,7]:
w = W[0]
The second if statement is never true due to a typo.
It should be x == [0,3,7].
Actually the bug is cleaned up later so the output should be correct anyways.
Change History (8)
comment:1 Changed 2 years ago by
| Branch: | → u/sbrandhorst/fix_an_if_statement_that_is_never_called_in_normal_form |
|---|
comment:2 Changed 2 years ago by
| Commit: | → 89467edba8a1dac0dd5192f1e78f13241daef5fb |
|---|---|
| Status: | new → needs_review |
comment:5 Changed 23 months ago by
| Commit: | 89467edba8a1dac0dd5192f1e78f13241daef5fb → 7d304d69f42b7ae930f8c91ab298e52427f0c24d |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 7d304d6 | Merge branch 'develop' into t/31374/fix_an_if_statement_that_is_never_called_in_normal_form
|
comment:7 Changed 23 months ago by
| Reviewers: | → Frédéric Chapoton |
|---|---|
| Status: | needs_review → positive_review |
comment:8 Changed 23 months ago by
| Branch: | u/sbrandhorst/fix_an_if_statement_that_is_never_called_in_normal_form → 7d304d69f42b7ae930f8c91ab298e52427f0c24d |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
clean up an if statement that is never called