Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#31372 closed defect (fixed)

Remove GAP, PARI, Singular Jupyter kernels from Docker image

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.3
Component: packages: optional Keywords:
Cc: chapoton, fbissey, arojas, vdelecroix Merged in:
Authors: Matthias Koeppe Reviewers: Frédéric Chapoton
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: 2cbfe78 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by slelievre)

(from https://groups.google.com/g/sage-release/c/hVIsURxpdhc/m/0h-_jT6mCQAJ)

pari_jupyter is not compatible with Python 3.9, breaks Docker build on GitLab.

Reported upstream at https://github.com/jdemeyer/pari_jupyter/issues/9

Given that, we simplify our Dockerfile to skip three optional packages it used to install: gap_jupyter, pari_jupyter, singular_jupyter.

Change History (12)

comment:1 Changed 2 years ago by mkoeppe

Cc: vdelecroix added
Description: modified (diff)
Report Upstream: N/AReported upstream. No feedback yet.

comment:2 Changed 2 years ago by mkoeppe

Branch: u/mkoeppe/pari_jupyter_is_not_compatible_with_python_3_9__breaks_docker_build_on_gitlab

comment:3 Changed 2 years ago by mkoeppe

Authors: Matthias Koeppe
Commit: 2cbfe787ddc1921d9e5880e8b73d903ac4bde8e9
Description: modified (diff)
Status: newneeds_review

New commits:

2cbfe78docker/Dockerfile: Do not reinstall standard packages with pip; do not install optional packages

comment:4 Changed 2 years ago by mkoeppe

Needs review.

comment:5 Changed 2 years ago by chapoton

I would prefer to comment out the line, with the idea to put it back when/if this is fixed

comment:6 Changed 2 years ago by mkoeppe

I removed them because they are optional packages, and I don't think the docker image should install them by default. If these packages should be present in every installation, someone should make the case for them to be standard packages -- which will ensure that they are actually tested.

comment:7 Changed 2 years ago by chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok

comment:8 Changed 2 years ago by mkoeppe

Thanks!

comment:9 Changed 2 years ago by slelievre

Description: modified (diff)
Summary: pari_jupyter is not compatible with python 3.9, breaks docker build on gitlabRemove GAP, PARI, Singular Jupyter kernels from Docker image

comment:10 Changed 2 years ago by slelievre

Description: modified (diff)

comment:11 Changed 2 years ago by vbraun

Branch: u/mkoeppe/pari_jupyter_is_not_compatible_with_python_3_9__breaks_docker_build_on_gitlab2cbfe787ddc1921d9e5880e8b73d903ac4bde8e9
Resolution: fixed
Status: positive_reviewclosed

comment:12 Changed 22 months ago by slelievre

Commit: 2cbfe787ddc1921d9e5880e8b73d903ac4bde8e9

Some pointers as we stop shipping the GAP, PARI and Singular Jupyter kernels in our Docker image.

The repo for the GAP Jupyter kernel is at:

To try GAP with Jupyter online, see:

The repo for the PARI Jupyter kernel is at:

Solving the issue that broke things here is tracked at:

See also "Run PARI/GP in your browser" including WebAssembly version:

The repo for the Singular Jupyter kernel is at:

See also the documentation page:

Note: See TracTickets for help on using tickets.