Opened 17 months ago

Closed 16 months ago

#31364 closed enhancement (fixed)

Don't use deprecated numpy type aliases

Reported by: arojas Owned by:
Priority: major Milestone: sage-9.3
Component: packages: standard Keywords:
Cc: mkoeppe, fbissey, slelievre Merged in:
Authors: Antonio Rojas Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 0f2f58a (Commits, GitHub, GitLab) Commit: 0f2f58a21177c537172aeb7e403c1dd2782cff0a
Dependencies: #31191 Stopgaps:

Status badges

Description (last modified by arojas)

The type aliases numpy.int, numpy.float and numpy.complex are deprecated in numpy 1.20, and the deprecation warnings cause lots of test failures.

We port these to the respective builtin types.

Change History (13)

comment:1 Changed 17 months ago by arojas

  • Branch set to u/arojas/don_t_use_deprecated_numpy_type_aliases

comment:2 Changed 17 months ago by arojas

  • Authors set to Antonio Rojas
  • Cc mkoeppe fbissey slelievre added
  • Commit set to 6544b79fb8b15bea46896ed2e4180f3ca4cd7c7b
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

Needs testing on older pythons

New commits:

​6544b79Don't use deprecated numpy type aliases

comment:3 Changed 17 months ago by mkoeppe

Looks like several import numpy as np can be removed from doctests

comment:4 Changed 17 months ago by mkoeppe

Testing on Python 3.6 is currently blocked by #31191

comment:5 Changed 16 months ago by mkoeppe

  • Dependencies set to #31191

comment:6 Changed 16 months ago by git

  • Commit changed from 6544b79fb8b15bea46896ed2e4180f3ca4cd7c7b to dfdef60515d4a4269e82d91280f76a7fdf10bf97

Branch pushed to git repo; I updated commit sha1. New commits:

​dfdef60Remove obsolete numpy imports

comment:7 Changed 16 months ago by mkoeppe

  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/584627033

comment:8 Changed 16 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/584627033 to https://github.com/mkoeppe/sage/actions/runs/584631860

comment:9 Changed 16 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/584631860 to Matthias Koeppe
  • Status changed from needs_review to positive_review

Looking OK also on ubuntu-bionic-standard (which uses system python 3.6) - ​https://github.com/mkoeppe/sage/runs/1942659778

comment:10 Changed 16 months ago by git

  • Commit changed from dfdef60515d4a4269e82d91280f76a7fdf10bf97 to cf7b513724fc5fd549a4c34f227fca231eb6d05e
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​cf7b513Merge branch 'develop' of git://git.sagemath.org/sage into t/31364/don_t_use_deprecated_numpy_type_aliases

comment:11 Changed 16 months ago by git

  • Commit changed from cf7b513724fc5fd549a4c34f227fca231eb6d05e to 0f2f58a21177c537172aeb7e403c1dd2782cff0a

Branch pushed to git repo; I updated commit sha1. New commits:

​0f2f58aFix merge

comment:12 Changed 16 months ago by arojas

  • Status changed from needs_review to positive_review

Rebased

comment:13 Changed 16 months ago by vbraun

  • Branch changed from u/arojas/don_t_use_deprecated_numpy_type_aliases to 0f2f58a21177c537172aeb7e403c1dd2782cff0a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.