Opened 8 months ago

Closed 7 months ago

#31362 closed enhancement (fixed)

make build-local, make build-venv

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: build Keywords:
Cc: gh-tobiasdiez, jhpalmieri, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 61f6ba6 (Commits, GitHub, GitLab) Commit: 61f6ba6ba917bc48a535470a5c781ccf57d94b06
Dependencies: #30912 Stopgaps:

Status badges

Description (last modified by mkoeppe)

The new make target build-local will build all non-Python packages that make build builds.

make build-venv will build all Python packages that make build builds.

Preparation for #30896, #30371 and related to #30913.

Change History (13)

comment:1 Changed 8 months ago by mkoeppe

  • Branch set to u/mkoeppe/make_all_sage_local__make_all_sage_venv

comment:2 Changed 8 months ago by git

  • Commit set to d7dc9a213894fbd12fa4991995b6f1244e5f3401

Branch pushed to git repo; I updated commit sha1. New commits:

d7dc9a2build/make/Makefile.in: New targets all-sage-local, all-sage-venv

comment:3 Changed 8 months ago by git

  • Commit changed from d7dc9a213894fbd12fa4991995b6f1244e5f3401 to 8796008d4852679266b786d63fef2933f0619fa1

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

2a91862build/pkgs/sagelib/src/README.rst: Add some text
6432727Merge tag '9.3.beta2' into t/30912/sagelib__update_metadata_for_pypi_deployment
4a693f2Move build/pkgs/sagelib/src/setup.cfg to SAGE_ROOT/src, replace by symlink
ea182d7Copy changes from build/pkgs/sagelib/src to src
a1a10b9src/VERSION.txt: New
5697335src/setup.cfg: Add license_file=LICENSE.txt
deb9eb3Merge tag '9.3.beta3' into t/30912/sagelib__update_metadata_for_pypi_deployment
7ad4c0eMerge tag '9.3.beta4' into t/30912/sagelib__update_metadata_for_pypi_deployment
27b589bMerge branch 't/30912/sagelib__update_metadata_for_pypi_deployment' into t/31362/make_all_sage_local__make_all_sage_venv
8796008Put pynac into SAGE_LOCAL, sagelib into SAGE_VENV

comment:4 Changed 8 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc jhpalmieri added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 8 months ago by mkoeppe

  • Dependencies set to #30912

comment:6 Changed 8 months ago by git

  • Commit changed from 8796008d4852679266b786d63fef2933f0619fa1 to d6831b1b9657035e91afe6c8b47b32358f24497c

Branch pushed to git repo; I updated commit sha1. New commits:

d6831b1build/make/Makefile.in: Add all-build-local, all-build-venv, which include dependency on toolchain

comment:7 Changed 8 months ago by git

  • Commit changed from d6831b1b9657035e91afe6c8b47b32358f24497c to 61f6ba6ba917bc48a535470a5c781ccf57d94b06

Branch pushed to git repo; I updated commit sha1. New commits:

61f6ba6Makefile: Add top-level targets build-local, build-venv

comment:8 Changed 8 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from make all-sage-local, make all-sage-venv to make build-local, make build-venv

comment:9 Changed 8 months ago by mkoeppe

  • Cc dimpase added

comment:10 Changed 8 months ago by mkoeppe

  • Description modified (diff)

comment:11 Changed 7 months ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

This does what it's supposed to. Let's merge it. If there are any bugs, they should be revealed in followup tickets.

comment:12 Changed 7 months ago by mkoeppe

Thank you!

comment:13 Changed 7 months ago by vbraun

  • Branch changed from u/mkoeppe/make_all_sage_local__make_all_sage_venv to 61f6ba6ba917bc48a535470a5c781ccf57d94b06
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.