#31323 closed enhancement (fixed)

Make self-diffeomorphisms default

Reported by: Tobias Diez Owned by:
Priority: major Milestone: sage-9.3
Component: manifolds Keywords:
Cc: Travis Scrimshaw, Nicolas M. Thiéry, Michael Jung, Eric Gourgoulhon, Matthias Köppe Merged in:
Authors: Tobias Diez Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 54d4cd3 (Commits, GitHub, GitLab) Commit: 54d4cd3a8b76f6d11cee805e7cbcc3a6fd0eaa22
Dependencies: Stopgaps:

Status badges


Currently, if you construct a diffeomorphism from a manifold to itself, you have to specify the manifold as the codmain. With the changes in this ticket, this is no longer necessary and we assume that the user want's to specify a self-diffeomorphism if no codomain is given.

Change History (5)

comment:1 Changed 22 months ago by Tobias Diez

Status: newneeds_review

comment:2 Changed 22 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Seems very reasonable and is in line with Hom. LGTM.

comment:3 Changed 22 months ago by Eric Gourgoulhon

Thanks for this improvement!

Side comment: when you open a ticket like this, could you please add it to the metaticket #30525 ? This helps keeping track on what's going on, especially to prepare the release tours and the changelogs. I've just done it for this ticket, as well as for #31322. Moreover the Cc field of Track is not 100% reliable (recently I've not been notified about some ticket while my username was added in Cc; such an issue has been already reported by others in the past).

Last edited 22 months ago by Eric Gourgoulhon (previous) (diff)

comment:4 Changed 22 months ago by Tobias Diez


Next time I'll also add them to the metaticket.

comment:5 Changed 21 months ago by Volker Braun

Branch: public/manifolds/diffeo_self_default54d4cd3a8b76f6d11cee805e7cbcc3a6fd0eaa22
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.