Opened 6 months ago

Closed 5 months ago

#31323 closed enhancement (fixed)

Make self-diffeomorphisms default

Reported by: gh-tobiasdiez Owned by:
Priority: major Milestone: sage-9.3
Component: manifolds Keywords:
Cc: tscrim, nthiery, gh-mjungmath, egourgoulhon, mkoeppe Merged in:
Authors: Tobias Diez Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 54d4cd3 (Commits, GitHub, GitLab) Commit: 54d4cd3a8b76f6d11cee805e7cbcc3a6fd0eaa22
Dependencies: Stopgaps:

Status badges

Description

Currently, if you construct a diffeomorphism from a manifold to itself, you have to specify the manifold as the codmain. With the changes in this ticket, this is no longer necessary and we assume that the user want's to specify a self-diffeomorphism if no codomain is given.

Change History (5)

comment:1 Changed 6 months ago by gh-tobiasdiez

  • Status changed from new to needs_review

comment:2 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Seems very reasonable and is in line with Hom. LGTM.

comment:3 Changed 6 months ago by egourgoulhon

Thanks for this improvement!

Side comment: when you open a ticket like this, could you please add it to the metaticket #30525 ? This helps keeping track on what's going on, especially to prepare the release tours and the changelogs. I've just done it for this ticket, as well as for #31322. Moreover the Cc field of Track is not 100% reliable (recently I've not been notified about some ticket while my username was added in Cc; such an issue has been already reported by others in the past).

Last edited 6 months ago by egourgoulhon (previous) (diff)

comment:4 Changed 6 months ago by gh-tobiasdiez

Thanks!

Next time I'll also add them to the metaticket.

comment:5 Changed 5 months ago by vbraun

  • Branch changed from public/manifolds/diffeo_self_default to 54d4cd3a8b76f6d11cee805e7cbcc3a6fd0eaa22
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.