Opened 9 months ago

Closed 8 months ago

#31322 closed enhancement (fixed)

Use ambient metric by default in hodge_dual

Reported by: gh-tobiasdiez Owned by:
Priority: major Milestone: sage-9.3
Component: manifolds Keywords:
Cc: tscrim, nthiery, gh-mjungmath, egourgoulhon, mkoeppe Merged in:
Authors: Tobias Diez Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4e8265d (Commits, GitHub, GitLab) Commit: 4e8265d88957b36f190f861fe5109e0e448a67f0
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

If no metric is specified for DiffForm#hodge_dual then now the ambient metric is used by default.

Moreover, I took the opportunity to let DiffFormParal derive from DiffForm, so that the former doesn't need to reimplement hodge_dual.

Change History (7)

comment:1 Changed 9 months ago by gh-tobiasdiez

  • Status changed from new to needs_review

comment:2 Changed 9 months ago by gh-tobiasdiez

  • Authors set to Tobias Diez

comment:3 Changed 9 months ago by slelievre

  • Description modified (diff)

comment:4 Changed 9 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 9 months ago by egourgoulhon

LGTM as well. Thanks for this improvement!

comment:6 Changed 9 months ago by gh-tobiasdiez

Thanks!

comment:7 Changed 8 months ago by vbraun

  • Branch changed from public/manifolds/hodge_dual_default to 4e8265d88957b36f190f861fe5109e0e448a67f0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.