Opened 10 months ago

Closed 9 months ago

#31321 closed enhancement (fixed)

build/pkgs: Add some missing install-requires metadata, add some documentation to the developer's guide

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: build Keywords:
Cc: slelievre, dimpase, fbissey, slabbe, jhpalmieri, gh-tobiasdiez Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f829357 (Commits, GitHub, GitLab) Commit: f82935770ab4b84fb167850b1a0341dbb52c3644
Dependencies: Stopgaps:

Status badges

Description

Dmitry Marakasov (repology.org) points out that some metadata are missing in our build/pkgs/. https://github.com/repology/repology-updater/issues/1118#issuecomment-771102608

We fix this so that the SageMath distribution can be listed as a repository on repology.org

Change History (13)

comment:1 Changed 10 months ago by mkoeppe

  • Branch set to u/mkoeppe/build_pkgs__add_some_missing_metadata

comment:2 Changed 10 months ago by mkoeppe

  • Commit set to 5a92c517b750b3320a997947b853052cff158aab
  • Summary changed from build/pkgs: Add some missing metadata to build/pkgs: Add some missing metadata, add some documentation to the developer's guide

New commits:

18466f0build/pkgs/wheel/install-requires.txt: New
8ec310esrc/doc/en/developer/packaging.rst: Explain install-requires.txt (from https://wiki.sagemath.org/ReleaseTours/sage-9.3)
5a92c51build/pkgs/texttable/install-requires.txt: New

comment:3 Changed 10 months ago by mkoeppe

#29152 adds the missing upstream_url fields for rw, cliquer, meataxe.

comment:4 Changed 10 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc jhpalmieri added
  • Priority changed from minor to major
  • Status changed from new to needs_review
  • Summary changed from build/pkgs: Add some missing metadata, add some documentation to the developer's guide to build/pkgs: Add some missing install-requires metadata, add some documentation to the developer's guide

comment:5 Changed 10 months ago by mkoeppe

  • Cc gh-tobiasdiez added

comment:6 Changed 10 months ago by slelievre

Should there be a space between >= and the version number?

In one case there is no space, in the other there is one:

texttable >=1.6.3
wheel >= 0.36.2

Wondering whether this matters here.

comment:7 Changed 10 months ago by git

  • Commit changed from 5a92c517b750b3320a997947b853052cff158aab to 52add22562d5cf057f57a296d50c24293c2b1b06

Branch pushed to git repo; I updated commit sha1. New commits:

52add22build/pkgs/wheel/install-requires.txt: No space after >=

comment:8 Changed 10 months ago by mkoeppe

Thanks for catching this, I want to standardize on the format without the space.

comment:9 Changed 10 months ago by mkoeppe

Needs review

comment:10 Changed 10 months ago by git

  • Commit changed from 52add22562d5cf057f57a296d50c24293c2b1b06 to f82935770ab4b84fb167850b1a0341dbb52c3644

Branch pushed to git repo; I updated commit sha1. New commits:

f829357Merge tag '9.3.beta7' into t/31321/build_pkgs__add_some_missing_metadata

comment:11 Changed 10 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:12 Changed 10 months ago by mkoeppe

Thanks!

comment:13 Changed 9 months ago by vbraun

  • Branch changed from u/mkoeppe/build_pkgs__add_some_missing_metadata to f82935770ab4b84fb167850b1a0341dbb52c3644
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.