Opened 22 months ago

Last modified 3 months ago

#31293 needs_work enhancement

sage.features: Move classes from __init__ to separate modules

Reported by: Matthias Köppe Owned by:
Priority: minor Milestone: sage-9.8
Component: refactoring Keywords:
Cc: Tobias Diez, Julian Rüth, François Bissey, Dima Pasechnik, Travis Scrimshaw, Sébastien Labbé Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: N/A Work issues: drop 2nd commit, rebase on #32925
Branch: u/mkoeppe/sage_features__move_classes_from___init___to_separate_modules (Commits, GitHub, GitLab) Commit: bad5d50a9d49b27af527319ff7990879917f03f4
Dependencies: Stopgaps:

Status badges

Description

In the long term we should get rid of __init__.py so that this package can become a namespace package (see #28925)

Change History (12)

comment:1 Changed 22 months ago by Matthias Köppe

Branch: u/mkoeppe/sage_features__move_classes_from___init___to_separate_modules

comment:2 Changed 22 months ago by git

Commit: bad5d50a9d49b27af527319ff7990879917f03f4

Branch pushed to git repo; I updated commit sha1. New commits:

bad5d50sage.features: Split out module feature

comment:3 Changed 22 months ago by Matthias Köppe

Cc: Julian Rüth added

comment:4 Changed 22 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:5 Changed 17 months ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: François Bissey Dima Pasechnik added
Status: newneeds_review

comment:6 Changed 17 months ago by François Bissey

This is just code re-org, you are just shuffling things around cut and paste style. Looks OK to me, but I'd like someone else to double check that I am not missing anything.

comment:7 Changed 17 months ago by Matthias Köppe

Cc: Travis Scrimshaw Sébastien Labbé added

comment:8 Changed 16 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

comment:9 Changed 12 months ago by Matthias Köppe

Status: needs_reviewneeds_work
Work issues: drop 2nd commit, rebase on #32925

comment:10 Changed 11 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:11 Changed 8 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:12 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8
Note: See TracTickets for help on using tickets.