Opened 23 months ago

Closed 21 months ago

Last modified 21 months ago

#31279 closed defect (fixed)

Add package argon2-cffi (dependency of Jupyter notebook)

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.3
Component: packages: standard Keywords:
Cc: Joshua Campbell, Samuel Lelièvre, Karl-Dieter Crisman, Dima Pasechnik, John Palmieri, Tobias Diez Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 45e5cd2 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

This is an install-requires of notebook.

In #26919 we did not add it, but if we let Python dependencies play out (for example as in #30913), it gets pulled in by sagelib via ipywidgets (see also #31278).

Change History (16)

comment:1 Changed 23 months ago by Matthias Köppe

Branch: u/mkoeppe/add_package_argon2_cffi

comment:2 Changed 23 months ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Joshua Campbell Samuel Lelièvre Karl-Dieter Crisman added
Commit: 3cec11b3db582d600607bb0b49193b22d185d804
Description: modified (diff)
Priority: minormajor
Status: newneeds_review
Summary: Add package argon2-cffiAdd package argon2-cffi (dependency of Jupyter notebook)

New commits:

f4273b7build/pkgs/argon2_cffi: New
3cec11bbuild/pkgs/notebook/dependencies: Add argon2_cffi

comment:3 Changed 22 months ago by Matthias Köppe

Cc: Dima Pasechnik John Palmieri added

comment:4 Changed 22 months ago by Matthias Köppe

Priority: majorcritical

comment:5 Changed 22 months ago by John Palmieri

I don't understand this ticket. If I build Sage and run the notebook, argon-cffi is not installed anywhere, as far as I can tell. What am I missing?

comment:6 Changed 22 months ago by Matthias Köppe

Cc: Tobias Diez added

We install all packages using pip install --no-deps (see build/bin/sage-pip-install), so dependencies that the package declares as install-requires are not automatically installed. As a result, I assume some feature of the Jupyter notebook must be unavailable; but I do not know what exactly.

comment:7 Changed 22 months ago by John Palmieri

argon2-cffi does something with password hashing, and I don't know if it's really necessary. I don't know enough about the security of the Jupyter notebook, or how argon2-cffi would help, to make a decision.

comment:9 Changed 22 months ago by gh-kliem

Reviewers: Jonathan Kliem

We need to set ARGON2_CFFI_USE_SSE2 to 0 in case of SAGE_FAT_BINARY.

https://argon2-cffi.readthedocs.io/en/stable/installation.html

comment:10 Changed 22 months ago by Matthias Köppe

Status: needs_reviewneeds_work

comment:11 Changed 22 months ago by git

Commit: 3cec11b3db582d600607bb0b49193b22d185d80445e5cd24f864ad35a176944cfe4d13840a962054

Branch pushed to git repo; I updated commit sha1. New commits:

45e5cd2build/pkgs/argon2_cffi/spkg-install.in: Handle SAGE_FAT_BINARY

comment:12 Changed 22 months ago by Matthias Köppe

Status: needs_workneeds_review

comment:13 Changed 22 months ago by gh-kliem

Status: needs_reviewpositive_review

LGTM.

comment:14 Changed 22 months ago by Matthias Köppe

Thank you!

comment:15 Changed 21 months ago by Volker Braun

Branch: u/mkoeppe/add_package_argon2_cffi45e5cd24f864ad35a176944cfe4d13840a962054
Resolution: fixed
Status: positive_reviewclosed

comment:16 Changed 21 months ago by Matthias Köppe

Commit: 45e5cd24f864ad35a176944cfe4d13840a962054

Follow up in #31441

Note: See TracTickets for help on using tickets.