Opened 23 months ago

Closed 21 months ago

Last modified 21 months ago

#31278 closed enhancement (fixed)

widgetsnbextension should not depend on notebook

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.3
Component: packages: standard Keywords:
Cc: François Bissey, Isuru Fernando, Antonio Rojas, Joshua Campbell, Tobias Diez, gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 5141bc3 (Commits, GitHub, GitLab) Commit:
Dependencies: #31328 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

This dependency pulls in a full installation of the Jupyter notebook.

notebook>=4.4.1->widgetsnbextension~=3.5.0->ipywidgets==7.5.1

This is an obstacle to avoiding to build a copy of the jupyter notebook (connecting to a system jupyter notebook).

The dependency is being removed in the widgetsnbextension 4.x series (currently alpha). We backport it to the stable release.

Change History (21)

comment:1 Changed 23 months ago by Matthias Köppe

Cc: Isuru Fernando Antonio Rojas added

comment:2 Changed 22 months ago by Matthias Köppe

In a first step we could patch out this dependency - then the wheel that we build at least won't pull the notebook into a user venv.

comment:3 Changed 22 months ago by Matthias Köppe

Cc: Joshua Campbell added

comment:4 Changed 22 months ago by Matthias Köppe

Cc: Tobias Diez added

comment:5 Changed 22 months ago by Matthias Köppe

Dependencies: #31328
Report Upstream: N/ANot yet reported upstream; Will do shortly.

comment:6 Changed 22 months ago by Matthias Köppe

Description: modified (diff)
Report Upstream: Not yet reported upstream; Will do shortly.Workaround found; Bug reported upstream.

comment:7 Changed 22 months ago by Matthias Köppe

Authors: Matthias Koeppe
Status: newneeds_review

comment:8 Changed 22 months ago by Matthias Köppe

Priority: majorcritical

comment:9 Changed 22 months ago by Matthias Köppe

Branch: u/mkoeppe/ipywidgets-should-not-depend-on-widgetsnbextension

comment:10 Changed 22 months ago by Matthias Köppe

Commit: 1062a3bc3359f7248a72f35ee23c519ab2a432bf

Upstream indicates in response to https://github.com/jupyter-widgets/ipywidgets/pull/3080 that they instead plan to remove the dependency of widgetsnbextension on notebook in 8.0.


New commits:

a8035aabuild/pkgs/ipywidgets: Upgrade to 7.6.3
fab1cb0build/pkgs/ipywidgets: Patch out dependency on widgetsnbextension, jupyterlab_widgets
1062a3bbuild/pkgs/ipywidgets/dependencies: Remove widgetsnbextension

comment:12 Changed 22 months ago by Matthias Köppe

Status: needs_reviewneeds_work

comment:13 Changed 22 months ago by Matthias Köppe

We can patch our widgetsnbextension with a backport of this.

comment:14 Changed 22 months ago by git

Commit: 1062a3bc3359f7248a72f35ee23c519ab2a432bf5141bc388f6834f68da8eb09bced2aa7c4641e83

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5141bc3build/pkgs/widgetsnbextension: Patch out dependency on notebook (backport from widgetsnbextension-4)

comment:15 Changed 22 months ago by Matthias Köppe

Description: modified (diff)
Report Upstream: Workaround found; Bug reported upstream.Fixed upstream, but not in a stable release.
Status: needs_workneeds_review
Summary: ipywidgets should not depend on widgetsnbextensionwidgetsnbextension should not depend on notebook

comment:16 Changed 22 months ago by Matthias Köppe

Cc: gh-kliem added

comment:17 Changed 21 months ago by Dima Pasechnik

this installs OK. More testing...

comment:18 Changed 21 months ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

lgtm

comment:19 Changed 21 months ago by Matthias Köppe

Thanks!

comment:20 Changed 21 months ago by Volker Braun

Branch: u/mkoeppe/ipywidgets-should-not-depend-on-widgetsnbextension5141bc388f6834f68da8eb09bced2aa7c4641e83
Resolution: fixed
Status: positive_reviewclosed

comment:21 Changed 21 months ago by Matthias Köppe

Commit: 5141bc388f6834f68da8eb09bced2aa7c4641e83

Follow up: #31523

Note: See TracTickets for help on using tickets.