Opened 2 years ago
Closed 2 years ago
#31272 closed enhancement (fixed)
Improve the documentation for tensor()
Reported by: | Travis Scrimshaw | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | documentation | Keywords: | |
Cc: | John Palmieri, Nicolas M. Thiéry | Merged in: | |
Authors: | Travis Scrimshaw | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | 368f533 (Commits, GitHub, GitLab) | Commit: | 368f533768d2f1f601df294024ed08ae1573a12d |
Dependencies: | Stopgaps: |
Description
Make it clear that it will also take elements as input.
Change History (8)
comment:1 Changed 2 years ago by
Branch: | → public/documentation/improve_tensor-31272 |
---|---|
Commit: | → 27b1ad8834c876824277a87f9c487004736876b0 |
Status: | new → needs_review |
comment:3 follow-up: 5 Changed 2 years ago by
Is that more than a typo? Were you planning to add more to that sentence and/or did the next line accidentally get deleted? If just a typo, I would delete `a, b
and add a period.
comment:4 Changed 2 years ago by
Commit: | 27b1ad8834c876824277a87f9c487004736876b0 → 368f533768d2f1f601df294024ed08ae1573a12d |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
368f533 | Removing errant line from previous thoughts.
|
comment:5 Changed 2 years ago by
Replying to jhpalmieri:
Is that more than a typo? Were you planning to add more to that sentence and/or did the next line accidentally get deleted? If just a typo, I would delete
`a, b
and add a period.
Actually, that was my previous attempt that I thought I had removed as I felt the line the preceding paragraph was a more natural place.
comment:6 Changed 2 years ago by
Reviewers: | → John Palmieri |
---|---|
Status: | needs_review → positive_review |
This looks good to me, thanks.
comment:8 Changed 2 years ago by
Branch: | public/documentation/improve_tensor-31272 → 368f533768d2f1f601df294024ed08ae1573a12d |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Here is an attempt to clarify things in the documentation.
New commits:
Improve the documentation in the tensor product to say it can take elements.