Opened 2 years ago

Closed 2 years ago

#31272 closed enhancement (fixed)

Improve the documentation for tensor()

Reported by: Travis Scrimshaw Owned by:
Priority: major Milestone: sage-9.3
Component: documentation Keywords:
Cc: John Palmieri, Nicolas M. Thiéry Merged in:
Authors: Travis Scrimshaw Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 368f533 (Commits, GitHub, GitLab) Commit: 368f533768d2f1f601df294024ed08ae1573a12d
Dependencies: Stopgaps:

Status badges

Description

Make it clear that it will also take elements as input.

Change History (8)

comment:1 Changed 2 years ago by Travis Scrimshaw

Branch: public/documentation/improve_tensor-31272
Commit: 27b1ad8834c876824277a87f9c487004736876b0
Status: newneeds_review

Here is an attempt to clarify things in the documentation.


New commits:

27b1ad8Improve the documentation in the tensor product to say it can take elements.

comment:2 Changed 2 years ago by Frédéric Chapoton

typo in the last modified line, see the diff (missing `)

comment:3 Changed 2 years ago by John Palmieri

Is that more than a typo? Were you planning to add more to that sentence and/or did the next line accidentally get deleted? If just a typo, I would delete `a, b and add a period.

Last edited 2 years ago by John Palmieri (previous) (diff)

comment:4 Changed 2 years ago by git

Commit: 27b1ad8834c876824277a87f9c487004736876b0368f533768d2f1f601df294024ed08ae1573a12d

Branch pushed to git repo; I updated commit sha1. New commits:

368f533Removing errant line from previous thoughts.

comment:5 in reply to:  3 Changed 2 years ago by Travis Scrimshaw

Replying to jhpalmieri:

Is that more than a typo? Were you planning to add more to that sentence and/or did the next line accidentally get deleted? If just a typo, I would delete `a, b and add a period.

Actually, that was my previous attempt that I thought I had removed as I felt the line the preceding paragraph was a more natural place.

comment:6 Changed 2 years ago by John Palmieri

Reviewers: John Palmieri
Status: needs_reviewpositive_review

This looks good to me, thanks.

comment:7 Changed 2 years ago by Travis Scrimshaw

Thank you for the review.

comment:8 Changed 2 years ago by Volker Braun

Branch: public/documentation/improve_tensor-31272368f533768d2f1f601df294024ed08ae1573a12d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.