#31263 closed defect (fixed)

Broken `sage -b`

Reported by: gh-kliem Owned by:
Priority: blocker Milestone: sage-9.3
Component: build Keywords:
Cc: mkoeppe Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: dff846c (Commits, GitHub, GitLab) Commit: dff846c11bce847f883a866dcc9c85b67932f7aa
Dependencies: Stopgaps:

Status badges

Description

#30622 broke sage -b.

Change History (9)

comment:1 Changed 12 months ago by gh-kliem

kliem@cofio:~/localhome/sage$ sage -b
Makefile:25: *** This Makefile needs to be invoked by build/make/install.  Stop.

comment:2 Changed 12 months ago by chapoton

indeed, this is rather annoying

comment:3 Changed 12 months ago by gh-kliem

  • Authors set to Jonathan Kliem
  • Branch set to public/31263
  • Commit set to fec4b0622eeb4f55f14cc6a3da6e5a832b44d006
  • Status changed from new to needs_review

New commits:

fec4b06fix sage -b after 30622

comment:4 follow-up: Changed 12 months ago by mkoeppe

I think a better fix would be to actually go through build/make/install

comment:5 Changed 12 months ago by git

  • Commit changed from fec4b0622eeb4f55f14cc6a3da6e5a832b44d006 to dff846c11bce847f883a866dcc9c85b67932f7aa

Branch pushed to git repo; I updated commit sha1. New commits:

dff846cgo through make/build/install

comment:6 in reply to: ↑ 4 Changed 12 months ago by gh-kliem

Replying to mkoeppe:

I think a better fix would be to actually go through build/make/install

Ok. Seems cleaner and seems to work for me.

comment:7 Changed 12 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:8 Changed 12 months ago by gh-kliem

Thank you.

comment:9 Changed 12 months ago by vbraun

  • Branch changed from public/31263 to dff846c11bce847f883a866dcc9c85b67932f7aa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.