Opened 9 months ago

Closed 9 months ago

#31255 closed enhancement (fixed)

Follow Up: Mutability of Sections and Tensor Fields

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.3
Component: manifolds Keywords:
Cc: tscrim, egourgoulhon Merged in:
Authors: Michael Jung Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 5f8472e (Commits, GitHub, GitLab) Commit: 5f8472e546d909297c1b13d4ae9a1b7c7ee57736
Dependencies: Stopgaps:

Status badges

Description

There are some missing checks from #30288 and #30274. They will be added here.

Change History (5)

comment:1 Changed 9 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/mutability_sections

comment:2 Changed 9 months ago by gh-mjungmath

  • Commit set to 5f8472e546d909297c1b13d4ae9a1b7c7ee57736
  • Status changed from new to needs_review

New commits:

​5f8472eTrac #31255: mutability check for set_comp and add_comp

comment:3 Changed 9 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:4 Changed 9 months ago by gh-mjungmath

That was fast. Thanks Matthias! :)

comment:5 Changed 9 months ago by vbraun

  • Branch changed from u/gh-mjungmath/mutability_sections to 5f8472e546d909297c1b13d4ae9a1b7c7ee57736
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.