Opened 7 months ago

Closed 6 months ago

#31243 closed enhancement (fixed)

Stronger Categories for Manifold Examples: Connectedness

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.3
Component: manifolds Keywords:
Cc: egourgoulhon, tscrim Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 440bc50 (Commits, GitHub, GitLab) Commit: 440bc5053d601a29538ac1640729f3719abe8932
Dependencies: #31233 Stopgaps:

Status badges

Description (last modified by gh-mjungmath)

Currently, an instance of OpenInterval just belongs to the category of smooth manifolds even though it is also connected. Similarly for Euclidean spaces and spheres.

The category of connected manifolds will be joined.

Part of metaticket #30189.

Change History (16)

comment:1 Changed 7 months ago by gh-mjungmath

  • Description modified (diff)

comment:2 Changed 7 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/stronger_categories_manifolds_examples

comment:3 Changed 7 months ago by gh-mjungmath

  • Commit set to 81a94a550ce71b638af365b3f7f2e82708c77234
  • Status changed from new to needs_review

New commits:

81a94a5Trac #31243: examples added to category of connected manifolds

comment:4 Changed 7 months ago by git

  • Commit changed from 81a94a550ce71b638af365b3f7f2e82708c77234 to c3c7ff0b05eb1d36c011bebfd4579fdb99a9a938

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c3c7ff0Trac #31243: examples added to category of connected manifolds

comment:5 Changed 7 months ago by gh-mjungmath

  • Dependencies set to #31233

comment:6 Changed 7 months ago by git

  • Commit changed from c3c7ff0b05eb1d36c011bebfd4579fdb99a9a938 to 1483634cf5d6084698482ec417dbcb8e57358b6c

Branch pushed to git repo; I updated commit sha1. New commits:

be52d78Trac #31233: meet categories
78f7af3Trac #31233: category of homset docstring adapted
8d31e0fTrac #31233: fixing format
111015dTrac #31233: adapt homsets in docstring
68de9c9Merge branch 't/31233/categories_for_homset_of_manifolds_do_not_meet' into stronger_categories_manifolds_examples
1483634Trac #31243: doctest conflicts with #31233

comment:7 follow-up: Changed 7 months ago by tscrim

It would be easier just to call the Connected() on the category:

-        category = Manifolds(RR).Smooth() & Manifolds(RR).Connected()
+        category = Manifolds(RR).Smooth().Connected()
-                       TopologicalSpaces().Compact() & Manifolds(RR).Connected()
+                       TopologicalSpaces().Compact().Connected()
Last edited 7 months ago by tscrim (previous) (diff)

comment:8 Changed 7 months ago by git

  • Commit changed from 1483634cf5d6084698482ec417dbcb8e57358b6c to 7f0de49bcd13308928238a598122b0995749fbee

Branch pushed to git repo; I updated commit sha1. New commits:

7f0de49Trac #31243: doctest missed

comment:9 in reply to: ↑ 7 Changed 7 months ago by gh-mjungmath

Replying to tscrim:

It would be easier just to call the Connected() on the category:

-        category = Manifolds(RR).Smooth() & Manifolds(RR).Connected()
+        category = Manifolds(RR).Smooth().Connected()
-                       TopologicalSpaces().Compact() & Manifolds(RR).Connected()
+                       TopologicalSpaces().Compact().Connected()

Indeed.

comment:10 Changed 7 months ago by git

  • Commit changed from 7f0de49bcd13308928238a598122b0995749fbee to 22df7718f71eb2a323bdf7e4838635c87b0b7edd

Branch pushed to git repo; I updated commit sha1. New commits:

22df771Trac #31241: call categories more comfortable + rearranged category order in doctest

comment:11 Changed 7 months ago by tscrim

Thank you. Green bot => positive review.

comment:12 Changed 7 months ago by git

  • Commit changed from 22df7718f71eb2a323bdf7e4838635c87b0b7edd to 440bc5053d601a29538ac1640729f3719abe8932

Branch pushed to git repo; I updated commit sha1. New commits:

440bc50Trac #31243: categories adapted in tutorial

comment:13 Changed 7 months ago by gh-mjungmath

Patchbot green.

comment:14 Changed 7 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:15 Changed 7 months ago by gh-mjungmath

Thanks.

comment:16 Changed 6 months ago by vbraun

  • Branch changed from u/gh-mjungmath/stronger_categories_manifolds_examples to 440bc5053d601a29538ac1640729f3719abe8932
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.