Opened 11 months ago

Closed 9 months ago

Last modified 9 months ago

#31242 closed enhancement (fixed)

Capitalize proper names in comments and docstrings

Reported by: chapoton Owned by:
Priority: trivial Milestone: sage-9.3
Component: documentation Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 038c698 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

We capitalize Cauchy, Cremona, Dirichlet, Gauss, Kronecker and Riemann in comments and docstrings where they appeared lowercase.

Change History (12)

comment:1 Changed 11 months ago by chapoton

  • Branch set to u/chapoton/31242
  • Commit set to e9fcb87d0838937de4e9cbcc5cd6822a399263d2
  • Status changed from new to needs_review

New commits:

e9fcb87adding a few capital letters to some names

comment:2 Changed 11 months ago by dcoudert

May be also

-    - ``dirichlet_coefficient`` - List of Dirichlet coefficients of the
+    - ``dirichlet_coefficient`` -- List of Dirichlet coefficients of the

comment:3 Changed 11 months ago by git

  • Commit changed from e9fcb87d0838937de4e9cbcc5cd6822a399263d2 to 9fc3c3a24a74acae8a123d85fe8a4ad5ad79bf71

Branch pushed to git repo; I updated commit sha1. New commits:

9fc3c3asome details in lcalc interface

comment:4 Changed 11 months ago by chapoton

voila

comment:5 Changed 11 months ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 9 months ago by vbraun

  • Status changed from positive_review to needs_work

You are patching lcalc output in doctests, that fails... ;-)

comment:7 Changed 9 months ago by git

  • Commit changed from 9fc3c3a24a74acae8a123d85fe8a4ad5ad79bf71 to 038c698fb6593495a4fb28e29785113e221c960c

Branch pushed to git repo; I updated commit sha1. New commits:

13c39c0Merge branch 'u/chapoton/31242' in 9.3.b8
038c698fix back doctests in lcalc

comment:8 Changed 9 months ago by chapoton

  • Status changed from needs_work to needs_review

indeed.. should be better now

comment:9 Changed 9 months ago by chapoton

David, tu veux bien re-passer en positif, stp ?

comment:10 Changed 9 months ago by dcoudert

  • Status changed from needs_review to positive_review

OK.

comment:11 Changed 9 months ago by vbraun

  • Branch changed from u/chapoton/31242 to 038c698fb6593495a4fb28e29785113e221c960c
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 Changed 9 months ago by slelievre

  • Commit 038c698fb6593495a4fb28e29785113e221c960c deleted
  • Description modified (diff)
  • Summary changed from adding some capital letters to names to Capitalize proper names in comments and docstrings
Note: See TracTickets for help on using tickets.