Opened 8 months ago

Closed 8 months ago

#31238 closed enhancement (fixed)

Add admcycles as an optional package

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-9.3
Component: packages: optional Keywords:
Cc: mkoeppe Merged in:
Authors: Vincent Delecroix Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 55ae682 (Commits, GitHub, GitLab) Commit: 55ae682e4fa69a5756c234fe5bf4c85ac5e93051
Dependencies: Stopgaps:

Status badges

Change History (11)

comment:1 Changed 8 months ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/31238
  • Cc mkoeppe added
  • Commit set to 82ec964df6e224dd4537f379a37ec66548682adc
  • Status changed from new to needs_review

New commits:

462fdb131236: fix hash function of permutations
82ec96431238: add admcycles as a pip package

comment:2 Changed 8 months ago by git

  • Commit changed from 82ec964df6e224dd4537f379a37ec66548682adc to 524362d8123539b8a458162e3fdbd6ecfd67351d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

524362d31238: add admcycles as a pip package

comment:3 Changed 8 months ago by mkoeppe

The file type is missing

comment:4 Changed 8 months ago by git

  • Commit changed from 524362d8123539b8a458162e3fdbd6ecfd67351d to 8a63120762e64787979feb9e1af38add245b9ede

Branch pushed to git repo; I updated commit sha1. New commits:

8a6312031238: type file

comment:5 Changed 8 months ago by vdelecroix

thanks. done.

comment:6 Changed 8 months ago by git

  • Commit changed from 8a63120762e64787979feb9e1af38add245b9ede to 8a92f01efed0283c5573c5194a2cbd139fa3c759

Branch pushed to git repo; I updated commit sha1. New commits:

8a92f0131238: more in SPKG.rst

comment:7 Changed 8 months ago by mkoeppe

No space before colon in title, start with a capital letter after colon, to match format in #29655

comment:8 Changed 8 months ago by git

  • Commit changed from 8a92f01efed0283c5573c5194a2cbd139fa3c759 to 55ae682e4fa69a5756c234fe5bf4c85ac5e93051

Branch pushed to git repo; I updated commit sha1. New commits:

55ae68231238: typographical conventions in SPKG.rst

comment:9 Changed 8 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:10 Changed 8 months ago by vdelecroix

Thanks

comment:11 Changed 8 months ago by vbraun

  • Branch changed from u/vdelecroix/31238 to 55ae682e4fa69a5756c234fe5bf4c85ac5e93051
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.