Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#31237 closed enhancement (fixed)

Add slabbe as an optional package

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-9.3
Component: packages: optional Keywords:
Cc: slabbe, mkoeppe Merged in:
Authors: Vincent Delecroix Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 39568a1 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Change History (15)

comment:1 Changed 5 months ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/31237
  • Cc mkoeppe added
  • Commit set to 2272e99364086c40c71a3b5e1eed425ed1b90473
  • Status changed from new to needs_review

New commits:

462fdb131236: fix hash function of permutations
2272e9931237: slabbe as optional pip package

comment:2 Changed 5 months ago by git

  • Commit changed from 2272e99364086c40c71a3b5e1eed425ed1b90473 to d54089a5d1a4f121df4ee4a8d240e7b1a19b6096

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d54089a31237: slabbe as optional pip package

comment:3 Changed 5 months ago by mkoeppe

type is missing

comment:4 follow-up: Changed 5 months ago by vdelecroix

Thanks. I used

$ sage -package create slabbe --pypi --source pip

Shouldn't this also create type?

Last edited 5 months ago by vdelecroix (previous) (diff)

comment:5 Changed 5 months ago by git

  • Commit changed from d54089a5d1a4f121df4ee4a8d240e7b1a19b6096 to 3d63d687d982f2272c73ba573855fec281e45b68

Branch pushed to git repo; I updated commit sha1. New commits:

3d63d6831237: type file

comment:6 Changed 5 months ago by vdelecroix

done

comment:7 Changed 5 months ago by git

  • Commit changed from 3d63d687d982f2272c73ba573855fec281e45b68 to ae174912c97107f9ac20f4771cb959a753533aa3

Branch pushed to git repo; I updated commit sha1. New commits:

ae1749131237: more in SPKG.rst

comment:8 Changed 5 months ago by chapoton

Et les accents dans "Sébastien Labbé" ?

comment:9 Changed 5 months ago by git

  • Commit changed from ae174912c97107f9ac20f4771cb959a753533aa3 to 69de74a4b37aea648e4cc96899629cb9ef000f5b

Branch pushed to git repo; I updated commit sha1. New commits:

69de74a31237: accent

comment:10 in reply to: ↑ 4 Changed 5 months ago by mkoeppe

Replying to vdelecroix:

Thanks. I used

$ sage -package create slabbe --pypi --source pip

Shouldn't this also create type?

I think it does if you use the branch from #29655

comment:11 Changed 5 months ago by git

  • Commit changed from 69de74a4b37aea648e4cc96899629cb9ef000f5b to 39568a1aa73cc30b15fb39293cded1692b4f2a43

Branch pushed to git repo; I updated commit sha1. New commits:

39568a131237: typographical conventions in SPKG.rst

comment:12 Changed 5 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:13 Changed 5 months ago by vdelecroix

Thanks

comment:14 Changed 5 months ago by vbraun

  • Branch changed from u/vdelecroix/31237 to 39568a1aa73cc30b15fb39293cded1692b4f2a43
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:15 Changed 5 months ago by slabbe

  • Commit 39568a1aa73cc30b15fb39293cded1692b4f2a43 deleted

Thanks for taking care of that. It was on my todo list. Sorry for being absent from the trac lately, I am busy with another house.

Note: See TracTickets for help on using tickets.