Opened 2 years ago

Closed 2 years ago

#31207 closed enhancement (fixed)

Implement copy for binary matrix

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.3
Component: basic arithmetic Keywords: copy, binary matrix
Cc: dcoudert Merged in:
Authors: Jonathan Kliem Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 5d37387 (Commits, GitHub, GitLab) Commit: 5d37387756878cf4e3a7aed4186f9122ff4fb2ff
Dependencies: #31200 Stopgaps:

Status badges

Description

This ticket implements an (unsafe) copy for binary matrix.

Change History (7)

comment:1 Changed 2 years ago by gh-kliem

Dependencies: #31200
Status: newneeds_review

comment:2 Changed 2 years ago by dcoudert

variable i should be defined.

comment:3 Changed 2 years ago by git

Commit: a7666b13df42f40a22ca29170f332136ebab4fcb5d37387756878cf4e3a7aed4186f9122ff4fb2ff

Branch pushed to git repo; I updated commit sha1. New commits:

5d37387declare type of i

comment:4 in reply to:  2 Changed 2 years ago by gh-kliem

Replying to dcoudert:

variable i should be defined.

Done.

comment:5 Changed 2 years ago by dcoudert

Reviewers: David Coudert
Status: needs_reviewpositive_review

LGTM.

comment:6 Changed 2 years ago by gh-kliem

Thank you.

comment:7 Changed 2 years ago by vbraun

Branch: u/gh-kliem/copy_binary_matrix5d37387756878cf4e3a7aed4186f9122ff4fb2ff
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.