Opened 19 months ago
Closed 19 months ago
#31200 closed enhancement (fixed)
Small improvements to binary matrix
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  basic arithmetic  Keywords:  binary matrix 
Cc:  tscrim, dcoudert  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  e008d42 (Commits, GitHub, GitLab)  Commit:  e008d42880df11e437f9fd8fce500fbf18d37766 
Dependencies:  Stopgaps: 
Description
We move binary_matrix.pxi to binary_matrix.pxd and add a realloc function.
Furthermore we add a few type specifications of the output and use mp_bitcnt
instead of Py_ssize_t
, as this is used in bitset_base.pxd.
Change History (8)
comment:1 Changed 19 months ago by
 Status changed from new to needs_review
comment:2 Changed 19 months ago by
 Reviewers set to David Coudert
comment:3 Changed 19 months ago by
 Commit changed from 8c95a04e56ad58a2c9379391bafc272cddf67cd2 to e008d42880df11e437f9fd8fce500fbf18d37766
Branch pushed to git repo; I updated commit sha1. New commits:
e008d42  remove redundant import

comment:4 Changed 19 months ago by
I don't think a .pyx file is needed. After all, we didn't have it there before.
And src/sage/geometry/polyhedron/combinatorial_polyhedron/face_data_structure.pxd
doesn't have a pyx file for it.
comment:5 Changed 19 months ago by
right, the usage is online with cimport.
For me this patch is OK. Thank you.
comment:6 Changed 19 months ago by
 Status changed from needs_review to positive_review
comment:7 Changed 19 months ago by
Thanks.
comment:8 Changed 19 months ago by
 Branch changed from u/ghkliem/improve_binary_matrix to e008d42880df11e437f9fd8fce500fbf18d37766
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I'm not sure
binary_matrix.pxd
should containIsn't it necessary to also get a .pyx file, even if empty ?