#31200 closed enhancement (fixed)

Small improvements to binary matrix

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.3
Component: basic arithmetic Keywords: binary matrix
Cc: tscrim, dcoudert Merged in:
Authors: Jonathan Kliem Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: e008d42 (Commits, GitHub, GitLab) Commit: e008d42880df11e437f9fd8fce500fbf18d37766
Dependencies: Stopgaps:

Status badges

Description

We move binary_matrix.pxi to binary_matrix.pxd and add a realloc function.

Furthermore we add a few type specifications of the output and use mp_bitcnt instead of Py_ssize_t, as this is used in bitset_base.pxd.

Change History (8)

comment:1 Changed 19 months ago by gh-kliem

  • Status changed from new to needs_review

comment:2 Changed 19 months ago by dcoudert

  • Reviewers set to David Coudert

I'm not sure binary_matrix.pxd should contain

+from sage.data_structures.binary_matrix cimport *

Isn't it necessary to also get a .pyx file, even if empty ?

comment:3 Changed 19 months ago by git

  • Commit changed from 8c95a04e56ad58a2c9379391bafc272cddf67cd2 to e008d42880df11e437f9fd8fce500fbf18d37766

Branch pushed to git repo; I updated commit sha1. New commits:

e008d42remove redundant import

comment:4 Changed 19 months ago by gh-kliem

I don't think a .pyx file is needed. After all, we didn't have it there before.

And src/sage/geometry/polyhedron/combinatorial_polyhedron/face_data_structure.pxd doesn't have a pyx file for it.

comment:5 Changed 19 months ago by dcoudert

right, the usage is online with cimport.

For me this patch is OK. Thank you.

comment:6 Changed 19 months ago by dcoudert

  • Status changed from needs_review to positive_review

comment:7 Changed 19 months ago by gh-kliem

Thanks.

comment:8 Changed 19 months ago by vbraun

  • Branch changed from u/gh-kliem/improve_binary_matrix to e008d42880df11e437f9fd8fce500fbf18d37766
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.