#31181 closed defect (fixed)

Mutability class does not return is_immutable

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.3
Component: misc Keywords:
Cc: tscrim, mkoeppe Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 5ecbf3a (Commits, GitHub, GitLab) Commit: 5ecbf3a4896e2ccc10f3f16d4100e197de6a6fea
Dependencies: Stopgaps:

Status badges

Description

At the current stage, the mixin class sage.structure.mutability.Mutability does not return anything for is_immutable:

    def is_immutable(self):
        """
        ...
        """
        self._is_immutable

Change History (5)

comment:1 Changed 11 months ago by gh-mjungmath

  • Status changed from new to needs_review

comment:2 Changed 11 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/mutability_class_does_not_return_is_immutable

comment:3 Changed 11 months ago by tscrim

  • Commit set to 5ecbf3a4896e2ccc10f3f16d4100e197de6a6fea
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Looks like a simple oversight, but the doctest is not actually testing this function. Well, this will work though.


New commits:

5ecbf3aTrac #31181: return added

comment:4 Changed 11 months ago by gh-mjungmath

Thanks for the quick review. Some doctests will be added with #30261 anyway. But first, we have to handle the pickling problem in #31182.

comment:5 Changed 10 months ago by vbraun

  • Branch changed from u/gh-mjungmath/mutability_class_does_not_return_is_immutable to 5ecbf3a4896e2ccc10f3f16d4100e197de6a6fea
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.