#31148 closed defect (fixed)

MR51: Allow Matplotlib to use system qhull >= 7.2.0

Reported by: galois Owned by:
Priority: minor Milestone: sage-9.3
Component: build Keywords:
Cc: slelievre Merged in:
Authors: Zachary Scherr Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 6a36667 (Commits, GitHub, GitLab) Commit: 6a3666745f6c0ce268f142a8c6ae984ec4ff4dff
Dependencies: #31128 Stopgaps:

Status badges

Description (last modified by slelievre)

zlscherr (@zlscherr) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/51:


My system has qhull 8.0.0 installed. Because Matplotlib
doesn't know about my system qhull it builds its own version.
This can cause runtime issues with Matplotlib trying to call
the wrong qhull library. For example, this fixes the error that

$ ./sage -tp 8 --long src/sage/plot/plot3d/list_plot3d.py

produces

QH6249 qh_lib_check: Incorrect qhull library called.
Size of qhT for caller is 2896, but for library is 2792.

QH6256 qh_lib_check: Cannot continue.
Library 'qhull 7.2.0 (2015.2 2016/01/18)'
uses a static qhT (e.g., libqhull.so)

if the system has qhull 8.0.0 installed.

Change History (12)

comment:1 Changed 18 months ago by gh-zlscherr

  • Component changed from PLEASE CHANGE to build
  • Description modified (diff)
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 18 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:3 Changed 18 months ago by slelievre

Full name in Author field please.

comment:4 Changed 18 months ago by gh-zlscherr

  • Authors changed from zlscherr to Zachary Scherr

comment:5 Changed 18 months ago by slelievre

  • Cc slelievre added
  • Description modified (diff)

Thanks!

comment:6 Changed 18 months ago by mkoeppe

The cffi upgrade that is on the ticket should be mentioned in the ticket description

comment:7 Changed 18 months ago by gh-zlscherr

Oops, that's my fault since I'm still learning about contributing. That was leftover from the last ticket I submitted as I had merged it into my local develop branch. Is there an easy way to separate those or should I just submit a new ticket? Sorry about that.

comment:8 Changed 18 months ago by mkoeppe

  • Dependencies set to #31128

As the branch is on top of the one of #31128, it's OK to just add that ticket as a dependency. I have just done that.

(Best practice, however, would be to have independent branches for independent tickets.)

comment:9 Changed 18 months ago by gh-zlscherr

Thanks.

Also, what is best practice for package dependencies? Matplotlib depends on numpy which depends on pkgconfig, which I use in this ticket. Does that mean I should explicitly add pkgconfig to Matplotlib's dependency file?

comment:10 Changed 18 months ago by mkoeppe

It would be clearer to add it explicitly; but it is correct as is because we currently do not use any system Python packages - and hence the indirect dependencies are guaranteed to be present.

comment:11 Changed 18 months ago by dimpase

I just opened #31165 to deal with system-wide qhull.

We should also update our qhull.

comment:12 Changed 17 months ago by vbraun

  • Branch changed from u/galois/mrs/51/matplotlib_qhull_fix to 6a3666745f6c0ce268f142a8c6ae984ec4ff4dff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.