Opened 18 months ago
Closed 17 months ago
#31146 closed defect (fixed)
cygwin-standard: fpylll build fails
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.3 |
Component: | packages: standard | Keywords: | |
Cc: | malb, gh-kliem | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Martin Albrecht |
Report Upstream: | Fixed upstream, in a later stable release. | Work issues: | |
Branch: | 1d379f7 (Commits, GitHub, GitLab) | Commit: | 1d379f723676354b7ea9c6e7bf314bf877a6ed8a |
Dependencies: | #31127 | Stopgaps: |
Description
https://github.com/kliem/sage/runs/1625789472
building 'fpylll.config' extension gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -O2 -g -march=native -O2 -g -march=native -Isrc/fpylll/fplll -I/opt/sage-255cf51a4f41b054d32a39562102877b0b18969f/include -I/opt/sage-255cf51a4f41b054d32a39562102877b0b18969f/lib/python3.8/site-packages/numpy/core/include -I/opt/sage-255cf51a4f41b054d32a39562102877b0b18969f/include/python3.8 -c build/src/fpylll/config.cpp -o build/temp.cygwin-3.1.7-x86_64-3.8/build/src/fpylll/config.o -std=c++11 -O2 -g -march=native build/src/fpylll/config.cpp: In function 'int __pyx_pymod_exec_config(PyObject*)': build/src/fpylll/config.cpp:1807:37: error: 'FPLLL_WITH_RECURSIVE_ENUM' was not declared in this scope 1807 | __pyx_t_4 = __Pyx_PyBool_FromLong(FPLLL_WITH_RECURSIVE_ENUM); if (unlikely(!__pyx_t_4)) __PYX_ERR(0, 40, __pyx_L1_error) | ^~~~~~~~~~~~~~~~~~~~~~~~~ error: command 'gcc' failed with exit status 1 Building wheel for fpylll (setup.py): finished with status 'error'
Attachments (2)
Change History (22)
comment:1 Changed 18 months ago by
comment:2 Changed 18 months ago by
The sage-local
artifact (huge!) generated by the build should contain it
comment:3 Changed 18 months ago by
Have you managed to download this? It is reportedly 7.4 GB but I'm only able to download 2.0GB.
comment:4 Changed 18 months ago by
Yes, I could download it but it turns out that it does not contain the package build directory; I'll investigate
comment:5 Changed 18 months ago by
Actually it's there, it is in sage-local-iv.tar
Changed 18 months ago by
comment:6 Changed 18 months ago by
Sorry, I need the fplll_config.h
file in FPLLL (without the "y"), and perhaps config.log
It should define FPLLL_WITH_RECURISVE_ENUM
but reportedly it doesn't. Which is odd.
Changed 18 months ago by
comment:7 Changed 18 months ago by
Here you go. The config.log
from the fplll
build was not saved by the run - it only keeps the build trees of failing packages.
comment:8 Changed 18 months ago by
Ta, found the bug. Cutting a new release.
comment:9 follow-up: ↓ 11 Changed 18 months ago by
What branch should base mine on?
comment:10 Changed 18 months ago by
- Report Upstream changed from N/A to Fixed upstream, in a later stable release.
comment:11 in reply to: ↑ 9 Changed 18 months ago by
comment:12 Changed 18 months ago by
Sorry, I'll need a bit of handholding here:
- I'd check out u/mkoeppe/ci_cygwinymladjust_to_new_script_packagesbootstrap_prereq from git://trac.sagemath.org/sage.git
- Do my update
- Push to GitHub? Which branch? I also might not have push rights to the GitHub repo
comment:13 Changed 18 months ago by
Our GH Actions workflows run on every tag and on every pull request. The procedure is documented here: https://doc.sagemath.org/html/en/developer/portability_testing.html#automatic-parallel-tox-runs-on-github-actions Any fork of the Sage repository with GH Actions enabled works for this purpose. I am using my fork at https://github.com/mkoeppe/sage
comment:14 Changed 18 months ago by
- Branch set to u/mkoeppe/cygwin_standard__fpylll_build_fails
comment:15 Changed 18 months ago by
- Commit set to 1d379f723676354b7ea9c6e7bf314bf877a6ed8a
- Dependencies set to #31127
comment:16 Changed 18 months ago by
- Reviewers set to https://github.com/mkoeppe/sage/actions/runs/489285130, https://github.com/mkoeppe/sage/actions/runs/489285125, https://github.com/mkoeppe/sage/actions/runs/489285124
- Status changed from new to needs_review
comment:17 Changed 18 months ago by
- Status changed from needs_review to positive_review
Looks good to me. Sorry for me not stepping up earlier, I had the patch prepared but apparently failed to push it.
comment:18 Changed 18 months ago by
- Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/489285130, https://github.com/mkoeppe/sage/actions/runs/489285125, https://github.com/mkoeppe/sage/actions/runs/489285124 to Martin Albrecht
comment:19 Changed 18 months ago by
cygwin-standard
- https://github.com/mkoeppe/sage/runs/1713927049
[fpylll-0.5.5] successfully installed.
comment:20 Changed 17 months ago by
- Branch changed from u/mkoeppe/cygwin_standard__fpylll_build_fails to 1d379f723676354b7ea9c6e7bf314bf877a6ed8a
- Resolution set to fixed
- Status changed from positive_review to closed
FPLLL_WITH_RECURISVE_ENUM
is something that's set infplll_config.h
byconfigure
. Is configure somehow not run on cygwin? Can I seefplll_config.h
produced by this run somewhere?