#31144 closed enhancement (fixed)

refresh the file polyhedron/plot.py

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.3
Component: geometry Keywords:
Cc: ​jipilab Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 50cbd58 (Commits, GitHub, GitLab) Commit: 50cbd58679218784b4ab7e8cab0f1705002a036f
Dependencies: Stopgaps:

Status badges

Description

fixing some lgtm warnings about mutation of default option values

plus a partial flake8 cleanup

Change History (7)

comment:1 Changed 18 months ago by chapoton

  • Branch set to u/chapoton/31144
  • Commit set to 92681e51388809ba4d29a44579eb55a1e0f38fc9
  • Status changed from new to needs_review

New commits:

92681e5refresh the file polyhedron/plot.py

comment:2 Changed 18 months ago by chapoton

  • Cc ​jipilab added

the bot is morally green, please review

comment:3 Changed 18 months ago by dcoudert

In methods render_0d, parameters line_opts and polygon_opts are not used. So why initializing them ? similar comment for other render_1/2/3d methods.

comment:4 Changed 18 months ago by git

  • Commit changed from 92681e51388809ba4d29a44579eb55a1e0f38fc9 to 50cbd58679218784b4ab7e8cab0f1705002a036f

Branch pushed to git repo; I updated commit sha1. New commits:

50cbd58do not initiate unused options

comment:5 Changed 18 months ago by chapoton

C'est vrai. Voilà donc un commit qui corrige la chose.

comment:6 Changed 18 months ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 17 months ago by vbraun

  • Branch changed from u/chapoton/31144 to 50cbd58679218784b4ab7e8cab0f1705002a036f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.