Opened 12 years ago

Closed 12 years ago

#3110 closed defect (fixed)

[with patch, positive review] rare pbuild dependency bug

Reported by: gfurnish Owned by: gfurnish
Priority: blocker Milestone: sage-3.0.2
Component: pbuild Keywords: pbuild
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This patch corrects a bug in pbuild dependency checking that does not correctly register the pxd file dependency for a pyx file if no other files cimport the file (rare).

Attachments (1)

trac_extcode_3110.patch (4.9 KB) - added by gfurnish 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by gfurnish

comment:1 Changed 12 years ago by gfurnish

  • Status changed from new to assigned

This patch also modifies -ba to clean the build directory.

comment:2 Changed 12 years ago by mabshoff

  • Summary changed from [with patch, needs review] rare pbuild dependency bug to [with patch, positive review] rare pbuild dependency bug

Path looks good to me. One thing: This patch also contains unrelated changes [besides the clean option] which are uncontroversial. I would suggest that you also add some release number that you increment on changes so we do not end up having to poke around for the exact version of pbuild when we need to debug some problem remotely.

Cheers,

Michael

comment:3 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.0.2.alpha0

Note: See TracTickets for help on using tickets.