#31096 closed enhancement (fixed)

some flake8 cleanup in abvar/

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.3
Component: algebraic geometry Keywords:
Cc: cremona, davidloeffler, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: faed739 (Commits, GitHub, GitLab) Commit: faed739a86884cf722855477b535f2339eaf61ef
Dependencies: Stopgaps:

Status badges

Description


Change History (12)

comment:1 Changed 12 months ago by chapoton

  • Branch set to u/chapoton/31096
  • Commit set to 13992d32bdbb1ec0bd6f144cc6a255e34c9c6941
  • Status changed from new to needs_review

New commits:

13992d3some flake8 for abvar/

comment:2 Changed 12 months ago by chapoton

  • Status changed from needs_review to needs_work

comment:3 Changed 12 months ago by git

  • Commit changed from 13992d32bdbb1ec0bd6f144cc6a255e34c9c6941 to e4c12fe2c1dce307ba63df47bce6df85f9764624

Branch pushed to git repo; I updated commit sha1. New commits:

e4c12feone more fix in abvar

comment:4 Changed 12 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:5 Changed 12 months ago by git

  • Commit changed from e4c12fe2c1dce307ba63df47bce6df85f9764624 to 83d9371ac3d13d6ae595e51102179b2d9b19f6fa

Branch pushed to git repo; I updated commit sha1. New commits:

83d9371not using sqrt_poly anymore

comment:6 Changed 12 months ago by chapoton

Should I remove "sqrt_poly", which is no longer used anywhere ?

comment:7 Changed 12 months ago by chapoton

  • Cc cremona davidloeffler tscrim added

morally green bot, please review

comment:8 Changed 12 months ago by dcoudert

Isn't it recommended to have only one import per line ? Also, one import has parenthesis and not the other.

+from .torsion_subgroup import RationalTorsionSubgroup, QQbarTorsionSubgroup
+from .finite_subgroup import (FiniteSubgroup_lattice, FiniteSubgroup, TorsionPoint)

Shouldn't we split the long strings in raise statements over several lines ?

comment:9 Changed 12 months ago by git

  • Commit changed from 83d9371ac3d13d6ae595e51102179b2d9b19f6fa to faed739a86884cf722855477b535f2339eaf61ef

Branch pushed to git repo; I updated commit sha1. New commits:

faed739breaking a few lines

comment:10 Changed 12 months ago by chapoton

ok, ok

comment:11 Changed 12 months ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:12 Changed 11 months ago by vbraun

  • Branch changed from u/chapoton/31096 to faed739a86884cf722855477b535f2339eaf61ef
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.