Opened 2 years ago
Closed 2 years ago
#31094 closed defect (fixed)
openssl: Make build more robust by clearing some environment variables
Reported by: | Matthias Köppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | packages: optional | Keywords: | |
Cc: | Thierry Monteil, gh-kliem, Dima Pasechnik | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | 5c169c7 (Commits, GitHub, GitLab) | Commit: | 5c169c73cbed3e65f007c7a8fa582ab9f6fc32bd |
Dependencies: | Stopgaps: |
Description
... in particular SYSTEM
, set by our tox.ini
, breaks the openssl build as seen in https://github.com/mkoeppe/sage/runs/1592276838:
[openssl-1.1.1i] Configuring openssl... [openssl-1.1.1i] Operating system: x86_64-whatever-$(build/bin/sage-guess-package-system) [openssl-1.1.1i] This system ($(build/bin/sage) is not supported. See file INSTALL for details. [openssl-1.1.1i] Error configuring openssl.
Change History (9)
comment:1 Changed 2 years ago by
Branch: | → u/mkoeppe/openssl__make_build_more_robust_by_clearing_some_environment_variables |
---|
comment:2 Changed 2 years ago by
Authors: | → Matthias Koeppe |
---|---|
Commit: | → 5c169c73cbed3e65f007c7a8fa582ab9f6fc32bd |
Status: | new → needs_review |
comment:3 Changed 2 years ago by
Cc: | gh-kliem added |
---|
comment:4 Changed 2 years ago by
Reviewers: | → https://github.com/kliem/sage/pull/31/checks |
---|
comment:5 Changed 2 years ago by
Build with this ticket merged went through in https://github.com/mkoeppe/sage/actions/runs/437548563 for #31082. Needs review
comment:6 Changed 2 years ago by
Cc: | Dima Pasechnik added |
---|
Still needs review, let's please get this in
comment:7 Changed 2 years ago by
Reviewers: | https://github.com/kliem/sage/pull/31/checks → Jonathan Kliem |
---|---|
Status: | needs_review → positive_review |
LGTM.
comment:9 Changed 2 years ago by
Branch: | u/mkoeppe/openssl__make_build_more_robust_by_clearing_some_environment_variables → 5c169c73cbed3e65f007c7a8fa582ab9f6fc32bd |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
build/pkgs/openssl/spkg-install.in: Unset some environment variables