#31094 closed defect (fixed)

openssl: Make build more robust by clearing some environment variables

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: packages: optional Keywords:
Cc: tmonteil, gh-kliem, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 5c169c7 (Commits, GitHub, GitLab) Commit: 5c169c73cbed3e65f007c7a8fa582ab9f6fc32bd
Dependencies: Stopgaps:

Status badges

Description

... in particular SYSTEM, set by our tox.ini, breaks the openssl build as seen in https://github.com/mkoeppe/sage/runs/1592276838:

  [openssl-1.1.1i]   Configuring openssl...
  [openssl-1.1.1i]   Operating system: x86_64-whatever-$(build/bin/sage-guess-package-system)
  [openssl-1.1.1i]   This system ($(build/bin/sage) is not supported. See file INSTALL for details.
  [openssl-1.1.1i]   Error configuring openssl.

Change History (9)

comment:1 Changed 12 months ago by mkoeppe

  • Branch set to u/mkoeppe/openssl__make_build_more_robust_by_clearing_some_environment_variables

comment:2 Changed 12 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 5c169c73cbed3e65f007c7a8fa582ab9f6fc32bd
  • Status changed from new to needs_review

New commits:

5c169c7build/pkgs/openssl/spkg-install.in: Unset some environment variables

comment:3 Changed 12 months ago by mkoeppe

  • Cc gh-kliem added

comment:4 Changed 12 months ago by gh-kliem

  • Reviewers set to https://github.com/kliem/sage/pull/31/checks

comment:5 Changed 11 months ago by mkoeppe

Build with this ticket merged went through in https://github.com/mkoeppe/sage/actions/runs/437548563 for #31082. Needs review

comment:6 Changed 11 months ago by mkoeppe

  • Cc dimpase added

Still needs review, let's please get this in

comment:7 Changed 11 months ago by gh-kliem

  • Reviewers changed from https://github.com/kliem/sage/pull/31/checks to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 11 months ago by mkoeppe

Thanks!

comment:9 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/openssl__make_build_more_robust_by_clearing_some_environment_variables to 5c169c73cbed3e65f007c7a8fa582ab9f6fc32bd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.