#31089 closed defect (fixed)

detect_poles puts a gap in function plots (even if there are no poles)

Reported by: gh-DaveWitteMorris Owned by:
Priority: minor Milestone: sage-9.3
Component: graphics Keywords: detect_poles, excluded point
Cc: Merged in:
Authors: Dave Morris Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3966dc7 (Commits, GitHub, GitLab) Commit: 3966dc790e46fa64443bd5d5279bd02bead86572
Dependencies: Stopgaps:

Status badges

Description

The following plot has a (big) gap around x = 0.

sage: plot(x, -1, 1, detect_poles=True, plot_points=30)
Launched png viewer for Graphics object consisting of 2 graphics primitives

The problem is that detect_poles uses 0 for the default value of exclusion_point. To fix this, we need a default value that is not in the plotting interval. (For example, we can add 1 to the right endpoint of the interval.)

Change History (7)

comment:1 Changed 12 months ago by gh-DaveWitteMorris

  • Branch set to public/31089

comment:2 Changed 12 months ago by gh-DaveWitteMorris

  • Commit set to 1984109138b63f5b4bfac9ac804fe2ca66a6359d
  • Status changed from new to needs_review

New commits:

1984109add trac number

comment:3 Changed 12 months ago by git

  • Commit changed from 1984109138b63f5b4bfac9ac804fe2ca66a6359d to 3966dc790e46fa64443bd5d5279bd02bead86572

Branch pushed to git repo; I updated commit sha1. New commits:

3966dc7trac 31089 fix doctests

comment:4 Changed 12 months ago by gh-DaveWitteMorris

Fixed 2 doctests. (These two graphs also demonstrated the bug, but it was necessary to look closely to see the gap.)

comment:5 Changed 12 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thanks

comment:6 Changed 12 months ago by gh-DaveWitteMorris

Thanks!

comment:7 Changed 11 months ago by vbraun

  • Branch changed from public/31089 to 3966dc790e46fa64443bd5d5279bd02bead86572
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.