#31081 closed enhancement (fixed)

get rid of _multiply

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.3
Component: combinatorics Keywords:
Cc: tscrim, slelievre Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d1a6707 (Commits, GitHub, GitLab) Commit: d1a6707bc7f08bca62b626c5eabf5ee0c7866f87
Dependencies: Stopgaps:

Status badges


that only appears in symmetric functions code

using instead the standard "product" method

Change History (6)

comment:1 Changed 12 months ago by chapoton

  • Branch set to u/chapoton/31081
  • Commit set to 52846c2a7f9f91366d1a69ecc9552132240eb100
  • Status changed from new to needs_review

New commits:

52846c2get rid of _multiply in symmetric functions

comment:2 Changed 11 months ago by chapoton

  • Cc tscrim slelievre added

bot is morally green, please review

comment:3 Changed 11 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

Minor point (and potential bikeshedding), but I think a NotImplementedError is the wrong error type since it suggests that it should be implemented at some point. I would go for either an assert or a TypeError. Once changed, you can set a positive review on my behalf.

comment:4 Changed 11 months ago by git

  • Commit changed from 52846c2a7f9f91366d1a69ecc9552132240eb100 to d1a6707bc7f08bca62b626c5eabf5ee0c7866f87

Branch pushed to git repo; I updated commit sha1. New commits:

d1a6707change error to TypeError

comment:5 Changed 11 months ago by chapoton

  • Status changed from needs_review to positive_review

thanks, done. Setting to positive now.

comment:6 Changed 11 months ago by vbraun

  • Branch changed from u/chapoton/31081 to d1a6707bc7f08bca62b626c5eabf5ee0c7866f87
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.