Opened 12 months ago

Closed 11 months ago

#31079 closed enhancement (fixed)

refresh Symmetric Group representations

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.3
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton, Travis Scrimshaw Reviewers: Travis Scrimshaw, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: e6bfc93 (Commits, GitHub, GitLab) Commit: e6bfc939f99c6507dc7cd3223615202108cf4437
Dependencies: Stopgaps:

Status badges

Description

as part of #12913

to get rid of CombinatorialClass

Change History (8)

comment:1 Changed 12 months ago by chapoton

  • Branch set to public/ticket/31079
  • Cc tscrim added
  • Commit set to 856fa06cb6a442d6bceb81b19a3f6b9c9316f4b0

Here is a first tentative, still failing. Needs help for investigating.

New commits:

​856fa06first work on symmetric group representations

comment:2 Changed 12 months ago by tscrim

You need to pass the parent to construct the representation/element. The generic parent SymmetricGroupRepresentations_class does not know about what the default ring should be. This is something set by the subclasses. I see two options:

1 - Implement a proper parent/element system with rewriting the (internal) construction paths to use P.element_class for the appropriate parent P. 2 - Just pass the correct object during the call of SymmetricGroupRepresentation.

1 takes more work, but it is the proper way to do it. 2 is quick and will work for now. I don't think 1 is too much more work, and I can do it if you want.

comment:3 Changed 12 months ago by chapoton

Hello, I am not sure that I am able to do either of what you propose. If you can, please do. Otherwise, I will try later.

comment:4 Changed 11 months ago by git

  • Commit changed from 856fa06cb6a442d6bceb81b19a3f6b9c9316f4b0 to 6f5da42523b557725b2c464c9c586c385b67154f

Branch pushed to git repo; I updated commit sha1. New commits:

​6f5da42Putting symmetric group reprs fully into the category framework.

comment:5 Changed 11 months ago by git

  • Commit changed from 6f5da42523b557725b2c464c9c586c385b67154f to e6bfc939f99c6507dc7cd3223615202108cf4437

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​e6bfc93Putting symmetric group reprs fully into the category framework.

comment:6 Changed 11 months ago by tscrim

  • Authors set to Frédéric Chapoton, Travis Scrimshaw
  • Reviewers set to Travis Scrimshaw, Frédéric Chapoton
  • Status changed from new to needs_review

Okay, here is a working branch.

comment:7 Changed 11 months ago by chapoton

  • Status changed from needs_review to positive_review

good, morally green bot and the changes looks good. I am setting to positive.

comment:8 Changed 11 months ago by vbraun

  • Branch changed from public/ticket/31079 to e6bfc939f99c6507dc7cd3223615202108cf4437
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.