Opened 12 months ago

Closed 11 months ago

#31068 closed enhancement (fixed)

some typos in rings/ and schemes/

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.3
Component: documentation Keywords:
Cc: slelievre Merged in:
Authors: Frédéric Chapoton Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: 4562ac7 (Commits, GitHub, GitLab) Commit: 4562ac7601a0ff27ad44fc6ae342dbbf01b1f922
Dependencies: Stopgaps:

Status badges

Description

found using 

sage --tox -e=codespell src/sage/rings/

Change History (8)

comment:1 Changed 12 months ago by chapoton

  • Branch set to u/chapoton/31068
  • Commit set to 5a940a0b924fef06353aae962427c27cb72413cd
  • Status changed from new to needs_review

New commits:

​5a940a0bunch of typos in rings/ and schemes/

comment:2 Changed 12 months ago by git

  • Commit changed from 5a940a0b924fef06353aae962427c27cb72413cd to 78212340f3c0a4be1ed205f35a9ee39271f8ebb6

Branch pushed to git repo; I updated commit sha1. New commits:

​7821234some details

comment:3 Changed 12 months ago by slelievre

Some optional suggestions while we are at it, but they can wait too.

While fixing "ambiguous" spelling, also change capitalisation. 

-            ValueError: Input is ambiguous: x as well as raw_element=42 are specified.
+            ValueError: input is ambiguous: x as well as raw_element=42 are specified.
...
-            raise ValueError('Input is ambiguous: '
+            raise ValueError('input is ambiguous: '

While fixing "guarentee" -> "guarantee", also fix "there is not" -> "there is no" and single or no backticks to double backticks. 

-         - A tuple (a, b, c) which satisfies `a = b*f + c*g`. There
-           is not guarantee that a, b, and c are minimal.
+         - A tuple ``(a, b, c)`` which satisfies ``a = b*f + c*g``. There
+           is no guarantee that ``a``, ``b``, and ``c`` are minimal.

Mis-spelled "seperate" incorrectly fixed to "saperate", should be "separate". 

-    We can represent the Berkovich projective line in two saperate ways:
+    We can represent the Berkovich projective line in two separate ways:

Fix "exceeds" as well as "allotted" (twice). 

-        However, if the Newton iteration exceedes the allotted attempts,
+        However, if the Newton iteration exceeds the allotted attempts,

Finally, whenever touching % or .format(...) string formatting, I would go f-strings, but up to you since you're doing the work!

comment:4 Changed 12 months ago by git

  • Commit changed from 78212340f3c0a4be1ed205f35a9ee39271f8ebb6 to e6fa6e6fde6f0d4c83f4541e45b2a363e8558202

Branch pushed to git repo; I updated commit sha1. New commits:

​e6fa6e6more fixes in rings and schemes

comment:5 Changed 12 months ago by git

  • Commit changed from e6fa6e6fde6f0d4c83f4541e45b2a363e8558202 to 4562ac7601a0ff27ad44fc6ae342dbbf01b1f922

Branch pushed to git repo; I updated commit sha1. New commits:

​4562ac7one more pyflakes fix

comment:6 Changed 12 months ago by slelievre

  • Reviewers set to Samuel Lelièvre

Positive review from me if bots are happy.

comment:7 Changed 11 months ago by chapoton

  • Status changed from needs_review to positive_review

ok, let's say that the bots are green enough

Merci Samuel

comment:8 Changed 11 months ago by vbraun

  • Branch changed from u/chapoton/31068 to 4562ac7601a0ff27ad44fc6ae342dbbf01b1f922
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.