#31062 closed defect (fixed)

tox / GH Actions: Disable testsuites of packages depending on pip packages (pytest, ...)

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.3
Component: porting Keywords:
Cc: jhpalmieri, gh-kliem, slabbe, dimpase, gh-tobiasdiez Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: b25ea3b (Commits, GitHub, GitLab) Commit: b25ea3bf32025a9e26fb214ed710b2aa6986a2f4
Dependencies: #30944 Stopgaps:

Status badges

Description (last modified by mkoeppe)

(from #30556)

... because we still don't have openssl on some platforms and so can't install pip packages.

We also make two minor fixes to package dependencies that are conditionalized on SAGE_CHECK:

  • sage_sws2rst was using the wrong variable for the conditionalization
  • rpy2 likes to have ipython available for tests (https://github.com/mkoeppe/sage/runs/1561098042):
    _____________ ERROR collecting src/rpy2/tests/ipython/test_html.py _____________
    ImportError while importing test module '/sage/local/var/tmp/sage/build/rpy2-3.3.6/src/rpy2/tests/ipython/test_html.py'.
    Hint: make sure your test modules/packages have valid Python names.
    Traceback:
    /usr/lib/python3.6/importlib/__init__.py:126: in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
    src/rpy2/tests/ipython/test_html.py:4: in <module>
        from rpy2.ipython import html
    src/rpy2/ipython/__init__.py:1: in <module>
        from . import rmagic
    src/rpy2/ipython/rmagic.py:89: in <module>
        from IPython.core import displaypub
    E   ModuleNotFoundError: No module named 'IPython'
    

Change History (12)

comment:1 Changed 12 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Description modified (diff)
  • Summary changed from tox / GH Actions: Disable testsuites of packages depending on pip packages (pytest, ...) if there is no ssl to tox / GH Actions: Disable testsuites of packages depending on pip packages (pytest, ...)

comment:2 Changed 12 months ago by mkoeppe

  • Branch set to u/mkoeppe/tox___gh_actions__disable_testsuites_of_packages_depending_on_pip_packages__pytest_______if_there_is_no_ssl

comment:3 Changed 12 months ago by mkoeppe

  • Commit set to 48657d2c4fdcee552a019aba8c0c9d06c87f7df6
  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/426748847

New commits:

9ad611dtox.ini, build/bin/write-dockerfile.sh: Add !sage_sws2rst, !rpy2 to SAGE_CHECK_PACKAGES
48657d2build/pkgs/sage_sws2rst/dependencies: Fix typo - use SAGE_CHECK_sage_sws2rst

comment:4 Changed 12 months ago by mkoeppe

  • Dependencies set to #30944

comment:5 Changed 12 months ago by git

  • Commit changed from 48657d2c4fdcee552a019aba8c0c9d06c87f7df6 to 380c718c885018749301cc0761f234598bd0dd19

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

559dd8etox.ini (local-root): Pass --enable-build-as-root to configure
a85f41ctox.ini (local): Do not build the toolchain when posargs = config.status or posargs = configure
1de912atox.ini (local-sudo): Run apt-get update with sudo
3c7e5c4tox.ini (local-root, local-sudo): Run output of sage-print-system-package-command through eval
571cc49Merge branch 't/30947/src_doc_bootstrap__simplify_by_using_new_options_of__sage__package_list_' into t/29124/script-packages-prereq-toolchain-bootstrap
f7ff30cMerge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/30944/tox__improve_local_sudo_ubuntu_standard
c529729Merge commit '3bb309944b7e8542b2ac88ed3c9d9a60e68644d7' of git://trac.sagemath.org/sage into t/29124/script-packages-prereq-toolchain-bootstrap
b73d6f0Merge tag '9.3.beta4' into t/29124/script-packages-prereq-toolchain-bootstrap
e9ca2c1Merge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/30944/tox__improve_local_sudo_ubuntu_standard
380c718Merge branch 't/30944/tox__improve_local_sudo_ubuntu_standard' into t/31062/tox___gh_actions__disable_testsuites_of_packages_depending_on_pip_packages__pytest_______if_there_is_no_ssl

comment:6 Changed 12 months ago by git

  • Commit changed from 380c718c885018749301cc0761f234598bd0dd19 to b25ea3bf32025a9e26fb214ed710b2aa6986a2f4

Branch pushed to git repo; I updated commit sha1. New commits:

b25ea3bbuild/pkgs/rpy2/dependencies: If SAGE_CHECK=yes, depend on ipython

comment:7 Changed 12 months ago by mkoeppe

  • Cc jhpalmieri gh-kliem slabbe added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:8 Changed 12 months ago by mkoeppe

  • Cc dimpase gh-tobiasdiez added

Let's please get this ticket in so that our CI runs work again normally

comment:9 Changed 12 months ago by mkoeppe

  • Priority changed from major to critical

comment:10 Changed 12 months ago by gh-kliem

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/426748847 to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

comment:11 Changed 12 months ago by mkoeppe

Thanks!

comment:12 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/tox___gh_actions__disable_testsuites_of_packages_depending_on_pip_packages__pytest_______if_there_is_no_ssl to b25ea3bf32025a9e26fb214ed710b2aa6986a2f4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.