#31061 closed enhancement (fixed)

Upgrade: GLPK 5.0

Reported by: slelievre Owned by:
Priority: major Milestone: sage-9.3
Component: packages: standard Keywords: GLPK, upgrade
Cc: arojas, dimpase, fbissey, gh-timokau, isuruf, jhpalmieri, mkoeppe, slelievre, thansen, mjo Merged in:
Authors: Antonio Rojas Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: b2cddf3 (Commits, GitHub, GitLab) Commit: b2cddf3efaa117e134850627df845cf763c66514
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

GLPK (GNU Linear Programming Kit) version 5.0 was released on 2020-12-16.

The last version was GLPK 4.65, released on 2018-02-16, to which we upgraded in #24824.

From the release notes of GLPK 5.0:

The copyright was transferred to the Free Software Foundation.

To fix some licensing problems the routines in the following files were disabled by replacing with dummy ones that print an error message:

  • src/api/gridgen.c
  • src/api/netgen.c
  • src/api/rmfgen.c
  • src/misc/qmd.c
  • src/misc/relax4.c

Note that this change does not affect the main functionality of the package.

Some minor bugs were fixed.

Upstream tarball:

Change History (8)

comment:1 Changed 12 months ago by slelievre

  • Cc arojas dimpase fbissey gh-timokau isuruf jhpalmieri mkoeppe slelievre thansen added
  • Description modified (diff)

comment:2 Changed 12 months ago by fbissey

  • Cc mjo added

comment:3 Changed 12 months ago by fbissey

It looks like the only significant change - packaging wise - is that the patch dont_print_Longstepwillbeused.patch is included. The main reason for the bump seems to be purely linked to the fact that the copyright was transferred to the FSF.

It remain to be seen if the removed functionality is used in sage at all.

comment:4 Changed 12 months ago by fbissey

The soname stayed the same with a small library version change from 40.3.0 to 40.3.1. Which means no change of interface. So it should just be a drop in replacement without needing recompilation.

comment:5 Changed 12 months ago by arojas

  • Branch set to u/arojas/upgrade__glpk_5_0

comment:6 Changed 12 months ago by arojas

  • Authors set to Antonio Rojas
  • Commit set to b2cddf3efaa117e134850627df845cf763c66514
  • Status changed from new to needs_review

All good on the tests front except for a minor output change


New commits:

d3c1f60Update glpk to 5.0
b2cddf3Make test pass with glpk 5.0

comment:7 Changed 12 months ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

LGTM

comment:8 Changed 11 months ago by vbraun

  • Branch changed from u/arojas/upgrade__glpk_5_0 to b2cddf3efaa117e134850627df845cf763c66514
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.