Opened 6 months ago

Closed 6 months ago

#31042 closed defect (fixed)

build/pkgs/_recommended: Remove duplication of the pandoc system package in debian, homebrew

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.3
Component: build: configure Keywords: sd111
Cc: slabbe, jhpalmieri Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: bdd5b9d (Commits, GitHub, GitLab) Commit: bdd5b9d606dafa14224fcf63092e877d1e24158d
Dependencies: Stopgaps:

Status badges

Description

(split out from #30930)

Although pandoc is installed in the system and is correctly detected by ./configure, it recommends installing it anyway.

This is due to the duplication of pandoc in the _recommended spkg.

In this ticket, we remove this duplication. As a result, when the system package is installed, ./configure will no longer recommend installing it.

We add pandoc separately to the autogenerated part of the documentation that is about "recommended system packages".

Change History (13)

comment:1 Changed 6 months ago by mkoeppe

  • Status changed from new to needs_review

comment:2 Changed 6 months ago by mkoeppe

  • Keywords sd111 added

comment:3 Changed 6 months ago by dimpase

The problem does not reproduce for me on 9.3.beta3 and pandoc installed and detected as accepted to be used. Are you sure this is needed?

comment:4 Changed 6 months ago by dimpase

  • Reviewers set to Dima Pasechnik

comment:5 Changed 6 months ago by dimpase

perhaps it is platform-specific? I checked on Fedora.

comment:6 follow-up: Changed 6 months ago by mkoeppe

comment:7 in reply to: ↑ 6 Changed 6 months ago by dimpase

Replying to mkoeppe:

You confirmed that it works in https://trac.sagemath.org/ticket/30930#comment:8

what made (?) a difference in a previous beta might not be needed any more, i.e. the problem has fixed itself?

comment:8 follow-up: Changed 6 months ago by mkoeppe

OK, we start from scratch. On your system, on the current beta without this ticket, what is the output from configure on your system?

comment:9 in reply to: ↑ 8 Changed 6 months ago by dimpase

Replying to mkoeppe:

OK, we start from scratch. On your system, on the current beta without this ticket, what is the output from configure on your system?

$ pandoc -v
pandoc 2.2.1
Compiled with pandoc-types 1.17.5.4, texmath 0.11.1.2, skylighting 0.7.5
...

$ ./configure
...
pandoc-none:                                 using system package; SPKG will not be installed
pandoc_attributes-8bc82f6d:                  does not support check for system package; optional, use "./configure --enable-pandoc_attributes" to install
pandocfilters-1.4.2:                         does not support check for system package; will be installed as an SPKG
...
configure:

    notice: the following SPKGs did not find equivalent system packages:

        _recommended cbc coxeter3 gp2c igraph isl libsemigroups pari_elldata pari_galpol pari_nftables pari_seadata

checking for the package system in use... fedora
configure:

    hint: installing the following system packages, if not
    already present, is recommended and may avoid having to
    build them (though some may have to be built anyway):

      $ sudo yum install  coin-or-Cbc coin-or-Cbc-devel coxeter coxeter-devel coxeter-tools igraph igraph-devel isl-devel pari-galpol pari-seadata

    After installation, re-run configure using:

      $ ./config.status --recheck && ./config.status

comment:10 Changed 6 months ago by mkoeppe

  • Summary changed from build/pkgs/_recommended: Remove duplication of the pandoc system package to build/pkgs/_recommended: Remove duplication of the pandoc system package in debian, homebrew

On Fedora, we have not even added anything yet to _recommended/distros, so there was nothing to remove.

$ ls build/pkgs/_recommended/distros
debian.txt    homebrew.txt  

comment:11 Changed 6 months ago by dimpase

  • Status changed from needs_review to positive_review

OK. Sorry for confusion

Last edited 6 months ago by dimpase (previous) (diff)

comment:12 Changed 6 months ago by mkoeppe

Thanks!

comment:13 Changed 6 months ago by vbraun

  • Branch changed from u/mkoeppe/add_update_the_system_package_information_for_the___recommended__dummy_package to bdd5b9d606dafa14224fcf63092e877d1e24158d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.