#31020 closed defect (fixed)

build/make/Makefile.in: Fix SAGE_CHECK logic, conditionalize sagetex dependencies on SAGE_CHECK

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.3
Component: build Keywords: sd111
Cc: jhpalmieri, dimpase, gh-kliem, mjo Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 1f714c1 (Commits, GitHub, GitLab) Commit: 1f714c119492a2540b74fc8e9521cc7204d4d28e
Dependencies: Stopgaps:

Status badges

Description

(from #30315)

As previously observed in #30324, the SAGE_CHECK logic implemented in #30118 and improved in #29766 still does not work correctly with dependencies conditionalized on SAGE_CHECK.

We fix it (again...?!) by moving the computation of the SAGE_CHECK_... variables earlier, before the dependencies are evaluated.

To test it, we conditionalize sagetex dependencies on SAGE_CHECK:

$ make sagetex-clean jmol-clean
$ make sagetex                    # should NOT build jmol
$ make sagetex-clean
$ SAGE_CHECK=yes make sagetex     # now it builds jmol

Change History (6)

comment:1 Changed 12 months ago by mkoeppe

  • Branch set to u/mkoeppe/build_make_makefile_in__fix_sage_check_logic__conditionalize_sagetex_dependencies_on_sage_check

comment:2 Changed 12 months ago by mkoeppe

  • Cc jhpalmieri dimpase added
  • Commit set to 1f714c119492a2540b74fc8e9521cc7204d4d28e
  • Status changed from new to needs_review

New commits:

0ed256cbuild/make/Makefile.in: Compute SAGE_CHECK_... earlier, before evaluating dependencies
1f714c1build/pkgs/sagetex/dependencies: Conditionalize order-only deps on SAGE_CHECK_sagetex

comment:3 Changed 12 months ago by mkoeppe

  • Cc gh-kliem mjo added
  • Keywords sd111 added

comment:4 Changed 12 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:5 Changed 12 months ago by mkoeppe

Thanks!

comment:6 Changed 12 months ago by vbraun

  • Branch changed from u/mkoeppe/build_make_makefile_in__fix_sage_check_logic__conditionalize_sagetex_dependencies_on_sage_check to 1f714c119492a2540b74fc8e9521cc7204d4d28e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.