Opened 2 years ago
Closed 2 years ago
#31020 closed defect (fixed)
build/make/Makefile.in: Fix SAGE_CHECK logic, conditionalize sagetex dependencies on SAGE_CHECK
Reported by: | Matthias Köppe | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.3 |
Component: | build | Keywords: | sd111 |
Cc: | John Palmieri, Dima Pasechnik, gh-kliem, Michael Orlitzky | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 1f714c1 (Commits, GitHub, GitLab) | Commit: | 1f714c119492a2540b74fc8e9521cc7204d4d28e |
Dependencies: | Stopgaps: |
Description
(from #30315)
As previously observed in #30324, the SAGE_CHECK
logic implemented in #30118 and improved in #29766 still does not work correctly with dependencies conditionalized on SAGE_CHECK
.
We fix it (again...?!) by moving the computation of the SAGE_CHECK_...
variables earlier, before the dependencies are evaluated.
To test it, we conditionalize sagetex
dependencies on SAGE_CHECK
:
$ make sagetex-clean jmol-clean $ make sagetex # should NOT build jmol $ make sagetex-clean $ SAGE_CHECK=yes make sagetex # now it builds jmol
Change History (6)
comment:1 Changed 2 years ago by
Branch: | → u/mkoeppe/build_make_makefile_in__fix_sage_check_logic__conditionalize_sagetex_dependencies_on_sage_check |
---|
comment:2 Changed 2 years ago by
Cc: | John Palmieri Dima Pasechnik added |
---|---|
Commit: | → 1f714c119492a2540b74fc8e9521cc7204d4d28e |
Status: | new → needs_review |
comment:3 Changed 2 years ago by
Cc: | gh-kliem Michael Orlitzky added |
---|---|
Keywords: | sd111 added |
comment:4 Changed 2 years ago by
Reviewers: | → Dima Pasechnik |
---|---|
Status: | needs_review → positive_review |
lgtm
comment:6 Changed 2 years ago by
Branch: | u/mkoeppe/build_make_makefile_in__fix_sage_check_logic__conditionalize_sagetex_dependencies_on_sage_check → 1f714c119492a2540b74fc8e9521cc7204d4d28e |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
build/make/Makefile.in: Compute SAGE_CHECK_... earlier, before evaluating dependencies
build/pkgs/sagetex/dependencies: Conditionalize order-only deps on SAGE_CHECK_sagetex