src/tox.ini: Rename pycodestyle to pycodestyle-minimal, add full pycodestyle as recommendation

[Tobias Diez]

The current pycodestyle configuration only covers a few rules that are also enforced by the patchbot. While this is a good starting point, IDEs pick up this configuration and only show warnings for these rules. In order to make sage's code adhere more to the pep8 recommendations, it is desirable to get warnings for all code style errors. Thus, in this ticket, we enable all pycodestyle warnings. These can be tested as usually by calling pycodestyle or tox -e pycodestyle. Moreover, the current minimal ruleset is tested via the new environment tox -e pycodestyle-minimal, which is also used in the new lint github action workflow.

[Matthias Köppe]

This is a good idea. Two points:

1) I think using pycodestyle-minimal would be more tox-ic (tox factor conditions)

2) I think envlist at the top should do pycodestyle-minimal, not pycodestyle. This affects the default when -e is not used.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​6f4cfb5

Implement feedback

[Tobias Diez]

Thanks for the review! I've now implemented your suggestions.

[Matthias Köppe]

In lint.yml, I think you don't need to install relint or pycodestyle because tox will take care of that in its virtual environment

[Matthias Köppe]

Also, the help message shown by sage -advanced needs some cosmetic adjustments because the longest environment name is longer now

[Tobias Diez]

Replying to mkoeppe:

In lint.yml, I think you don't need to install relint or pycodestyle because tox will take care of that in its virtual environment

You are probably right, but that's not really related to this ticket.

[Tobias Diez]

Replying to mkoeppe:

Also, the help message shown by sage -advanced needs some cosmetic adjustments because the longest environment name is longer now

I'm not sure what you mean, but sage -advanced doesn't show any tox-related infos for me (but the indent for example ecl is off). Maybe it's because I also get the following error when running sage:

/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 3: __requires__: command not found
/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 4: syntax error near unexpected token `'pkg_resources''
/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 4: `__import__('pkg_resources').require('sage==9.3b2')'

[Matthias Köppe]

Replying to gh-tobiasdiez:

I also get the following error when running sage:

/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 3: __requires__: command not found
/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 4: syntax error near unexpected token `'pkg_resources''
/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 4: `__import__('pkg_resources').require('sage==9.3b2')'

This is an interesting error - something seems to be rewriting this shell scripts as if it is a Python script - perhaps the newest version of pip?

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​064b8c6	Merge tag '9.3.beta3' into t/31004/public/build/minimal_codestyle
​a0d9b59	src/bin/sage --advanced: Show all tox environments, adjust alignment

[Matthias Köppe]

Replying to mkoeppe:

Also, the help message shown by sage -advanced needs some cosmetic adjustments because the longest environment name is longer now

Done

[Tobias Diez]

Replying to mkoeppe:

Replying to mkoeppe:

Also, the help message shown by sage -advanced needs some cosmetic adjustments because the longest environment name is longer now

Done

Thanks!

[Tobias Diez]

Replying to mkoeppe:

Replying to gh-tobiasdiez:

I also get the following error when running sage:

/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 3: __requires__: command not found
/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 4: syntax error near unexpected token `'pkg_resources''
/mnt/d/Programming/sage/src/.venv/bin/sage-version.sh: line 4: `__import__('pkg_resources').require('sage==9.3b2')'

This is an interesting error - something seems to be rewriting this shell scripts as if it is a Python script - perhaps the newest version of pip?

Maybe because I invoke sage from within pipenv shell (to activate the correct venv)?

[Matthias Köppe]

Let's investigate this in #31049. It's not related to this ticket.

[Matthias Köppe]

Ready for review...

[Matthias Köppe]

Is there a reviewer for my changes on this ticket?

[Tobias Diez]

The other changes look good to me as well. Thanks!