#30979 closed defect (fixed)

Remove duplication of options handled in src/bin/sage and build/bin/sage-site

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.3
Component: scripts Keywords:
Cc: jhpalmieri, slabbe, gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 87dad36 (Commits, GitHub, GitLab) Commit: 87dad365d73c1d57cd65387866f5c949d9caba7c
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

(from #30846)

We remove the duplication of lines like

if [ "$1" = '-optional' -o "$1" = "--optional" ]; then
    shift
    exec sage-list-packages optional $@
fi

in src/bin/sage and build/bin/sage-site.

We keep handling of the option --installed in src/bin/sage in anticipation of #30940 (src/bin/sage-list-packages: Make it work if SAGE_ROOT is not available).

Change History (6)

comment:1 Changed 12 months ago by mkoeppe

  • Branch set to u/mkoeppe/remove_duplication_of_options_handled_in_src_bin_sage_and_build_bin_sage_site

comment:2 Changed 12 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 87dad365d73c1d57cd65387866f5c949d9caba7c
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

87dad36src/bin/sage, build/bin/sage-site: Remove duplication of options -installed, -p, -package, -optional, -experimental, -standard

comment:3 Changed 11 months ago by mkoeppe

  • Cc slabbe added

comment:4 Changed 11 months ago by mkoeppe

  • Cc gh-kliem added

comment:5 Changed 11 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/remove_duplication_of_options_handled_in_src_bin_sage_and_build_bin_sage_site to 87dad365d73c1d57cd65387866f5c949d9caba7c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.