#30971 closed enhancement (fixed)

Update to pillow 8.0.1

Reported by: arojas Owned by:
Priority: major Milestone: sage-9.3
Component: packages: standard Keywords:
Cc: mkoeppe, isuruf, gh-timokau, fbissey, egourgoulhon Merged in:
Authors: Antonio Rojas Reviewers: Matthias Koeppe, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f05f2d0 (Commits, GitHub, GitLab) Commit: f05f2d0aac9c4b5abe68105cee2cc7f2c8461847
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

the interface needed tweaking to let Sage inetegers to be used.

Without this tweak, it caused some test failures in sage/repl/image.py because Sage integers are not allowed for the color property. Until now, one could bypass the type check by putting the integer in a 1-tuple, but that no longer works in 8.0

This also fixes an issue with header names (present pillow has Zip.h, which may clash on macOS with zip.h) - this is fixed in 8.0.

Change History (6)

comment:1 Changed 13 months ago by arojas

  • Branch set to u/arojas/update_to_pillow_8_0_1

comment:2 Changed 13 months ago by arojas

  • Authors set to Antonio Rojas
  • Cc mkoeppe isuruf gh-timokau fbissey added
  • Commit set to 72859891294ec5c39f04513c8154f93c7a43b2c3
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

3e813c9Update pillow to 8.0.1
7285989Use Python integers for color

comment:3 Changed 12 months ago by mkoeppe

  • Cc egourgoulhon added

Wouldn't it be better to keep the interface and attempt to convert Sage integers? This has the potential to break user code

comment:4 Changed 12 months ago by git

  • Commit changed from 72859891294ec5c39f04513c8154f93c7a43b2c3 to f05f2d0aac9c4b5abe68105cee2cc7f2c8461847

Branch pushed to git repo; I updated commit sha1. New commits:

f05f2d0Support Sage integers in the color property for Sage's Image class

comment:5 Changed 12 months ago by dimpase

  • Description modified (diff)
  • Reviewers set to Matthias Koeppe, Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:6 Changed 12 months ago by vbraun

  • Branch changed from u/arojas/update_to_pillow_8_0_1 to f05f2d0aac9c4b5abe68105cee2cc7f2c8461847
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.