Opened 20 months ago

Closed 5 months ago

#30933 closed defect (fixed)

GH Actions: Repair upload of docker images to docker.pkg.github.com

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.5
Component: porting Keywords:
Cc: gh-kliem, dimpase, gh-tobiasdiez Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 21afe51 (Commits, GitHub, GitLab) Commit: 21afe511f1e903647102127204f47c2d29e04fef
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

These docker images are built by the portability CI workflows for Linux.

However, refactoring of the workflow had broken the upload to docker.pkg.github.com. (Although the login to docker.pkg.github.com succeeds, the push fails with no basic auth credentials - see https://github.com/mkoeppe/sage/runs/1414148202?check_suite_focus=true)

Change History (18)

comment:1 Changed 20 months ago by mkoeppe

This is possibly because tox does not pass on $HOME - and docker login stores the password in /home/runner/.docker/config.json.

comment:2 Changed 20 months ago by mkoeppe

docker login recommends to configure a credential helper - https://docs.docker.com/engine/reference/commandline/login/#credentials-store

comment:3 Changed 20 months ago by mkoeppe

  • Branch set to u/mkoeppe/gh_actions__repair_upload_of_docker_images

comment:4 Changed 20 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 1bb3b3349c751dbeb0d376b29a45c1c55088df85
  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/369629393

New commits:

e8afd96.github/workflows/tox*.yml: Use new method to set environment variable for next GH Actions steps
1bb3b33.github/workflows/tox*.yml: Install pass for docker push

comment:5 Changed 20 months ago by mkoeppe

  • Reviewers https://github.com/mkoeppe/sage/actions/runs/369629393 deleted

comment:6 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

comment:7 Changed 11 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

comment:8 Changed 6 months ago by mkoeppe

  • Milestone changed from sage-9.5 to sage-9.6

comment:9 Changed 6 months ago by mkoeppe

  • Summary changed from GH Actions: Repair upload of docker images to GH Actions: Repair upload of docker images to docker.pkg.github.com

comment:10 Changed 6 months ago by git

  • Commit changed from 1bb3b3349c751dbeb0d376b29a45c1c55088df85 to 064425907b0d7f909a779420062c83923008b808

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0644259.github/workflows/tox*.yml, tox.ini: Pass ddocker.pkg.github.com credentials via DOCKER_CONFIG_FILE

comment:11 Changed 6 months ago by mkoeppe

  • Dependencies #30733 deleted
  • Milestone changed from sage-9.6 to sage-9.5
  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/1641828444
  • Status changed from new to needs_review

comment:12 Changed 6 months ago by git

  • Commit changed from 064425907b0d7f909a779420062c83923008b808 to 21afe511f1e903647102127204f47c2d29e04fef

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

21afe51.github/workflows/tox*.yml, tox.ini: Pass ddocker.pkg.github.com credentials via DOCKER_CONFIG_FILE

comment:13 Changed 6 months ago by mkoeppe

  • Description modified (diff)
  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/1641828444 to https://github.com/mkoeppe/sage/runs/4676511083?check_suite_focus=true

comment:14 Changed 6 months ago by dimpase

  • Reviewers changed from https://github.com/mkoeppe/sage/runs/4676511083?check_suite_focus=true to Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, Happy New Year :-)

comment:15 Changed 6 months ago by mkoeppe

Thanks Dima, happy new year to you too!

comment:16 Changed 6 months ago by mkoeppe

  • Priority changed from major to critical

comment:17 Changed 5 months ago by mkoeppe

  • Priority changed from critical to blocker

comment:18 Changed 5 months ago by vbraun

  • Branch changed from u/mkoeppe/gh_actions__repair_upload_of_docker_images to 21afe511f1e903647102127204f47c2d29e04fef
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.