Opened 21 months ago
Closed 20 months ago
#30929 closed enhancement (fixed)
GH Actions: Update macos test environments
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.3 |
Component: | porting | Keywords: | |
Cc: | jhpalmieri, dimpase | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | 7ae8cf1 (Commits, GitHub, GitLab) | Commit: | 7ae8cf13e81a8b6f719302568e66e36e82996cd9 |
Dependencies: | Stopgaps: |
Description (last modified by )
https://github.com/actions/virtual-environments
Big Sur:
https://github.com/actions/virtual-environments/issues/1814: macOS Big Sur (11.0) is available as a preview for GitHub Action users!
To use it set
runs-on: macos-11.0
in your workflow file.
Details: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11.0-Readme.md
- 12.3 (beta) 12C5020f /Applications/Xcode_12.3.app
- 12.2 12B5044c /Applications/Xcode_12.2.app
- 11.7 (default) 11E801a /Applications/Xcode_11.7.app
Catalina: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md
- 12.3 (beta) 12C5020f /Applications/Xcode_12.3.app
- 12.2 12B45b /Applications/Xcode_12.2.app
- 12.1.1 12A7605b /Applications/Xcode_12.1.1.app
- 12.1 12A7403 /Applications/Xcode_12.1.app
- 12.0.1 (default) 12A7300 /Applications/Xcode_12.app
- 11.7 11E801a /Applications/Xcode_11.7.app
Previous update: #30487 - which added testing with Xcode 12 on Catalina.
See also: #30726 GH Actions: Test optional/experimental packages with Xcode 12
Change History (17)
comment:1 Changed 21 months ago by
- Description modified (diff)
comment:2 Changed 21 months ago by
- Description modified (diff)
comment:3 Changed 21 months ago by
- Branch set to u/mkoeppe/gh_actions__update_macos_test_environments
comment:4 Changed 21 months ago by
- Commit set to 8df49f1f2d14dca9c643af7d30c9c0e9c8b4a08b
- Reviewers set to https://github.com/mkoeppe/sage/actions/runs/367209097
comment:5 Changed 21 months ago by
- Commit changed from 8df49f1f2d14dca9c643af7d30c9c0e9c8b4a08b to ee388dccf5c52360e0bcafbffffd844c98e16977
(wrong ticket)
comment:6 Changed 21 months ago by
New commits:
ee388dc | .github/workflows/tox*.yml: Use new method to set environment variable for next GH Actions steps
|
comment:7 Changed 21 months ago by
- Commit changed from ee388dccf5c52360e0bcafbffffd844c98e16977 to 8df49f1f2d14dca9c643af7d30c9c0e9c8b4a08b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
comment:8 Changed 21 months ago by
- Description modified (diff)
comment:9 Changed 21 months ago by
- Description modified (diff)
comment:10 follow-up: ↓ 11 Changed 21 months ago by
I'm a bit confused that you use
+ runs-on: ${{ matrix.os }}
before declaring it.
The other thing is that things have moved on already. Beta 12.3 is available and 12.2 is the default, once this ticket is merged (and no longer beta). So the description of this ticket should be updated accordingly.
Does it make sense to test 12.3 already?
Otherwise this looks fine.
comment:11 in reply to: ↑ 10 Changed 21 months ago by
Replying to gh-kliem:
I'm a bit confused that you use
+ runs-on: ${{ matrix.os }}before declaring it.
Whatever works is part of the operational semantics of this language
comment:12 Changed 21 months ago by
- Description modified (diff)
comment:13 Changed 21 months ago by
- Commit changed from 8df49f1f2d14dca9c643af7d30c9c0e9c8b4a08b to 7ae8cf13e81a8b6f719302568e66e36e82996cd9
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
92221b9 | .github/workflows/tox.yml: Test with macOS 11, update Xcode versions
|
ce2a3c5 | .github/workflows/tox.yml: Test Xcode 11.7, default, 12.3
|
7ae8cf1 | .github/workflows/tox-{optional,experimental}.yml: Update macos jobs
|
comment:14 Changed 21 months ago by
- Status changed from new to needs_review
comment:15 Changed 21 months ago by
- Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/367209097 to Jonathan Kliem
- Status changed from needs_review to positive_review
LGTM.
comment:16 Changed 21 months ago by
Thanks!
comment:17 Changed 20 months ago by
- Branch changed from u/mkoeppe/gh_actions__update_macos_test_environments to 7ae8cf13e81a8b6f719302568e66e36e82996cd9
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
.github/workflows/tox.yml: Test with macOS 11, update Xcode versions