Opened 2 years ago

Closed 2 years ago

#30904 closed enhancement (fixed)

changes in shuffle_product

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.3
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 760ca5d (Commits, GitHub, GitLab) Commit: 760ca5d00160564055aa2e6530094356eb0693b3
Dependencies: Stopgaps:

Status badges

Description

mainly replacing CombinatorialClass? with Parent+EnumeratedSet?

another step towards #12913

Change History (5)

comment:1 Changed 2 years ago by chapoton

Branch: u/chapoton/30904
Commit: bd8ac8e7d512e404035718f84ea1a14bf64b75a7
Status: newneeds_review

New commits:

bd8ac8eget rid of CombinatorialClass in shuffle_product

comment:2 Changed 2 years ago by git

Commit: bd8ac8e7d512e404035718f84ea1a14bf64b75a7760ca5d00160564055aa2e6530094356eb0693b3

Branch pushed to git repo; I updated commit sha1. New commits:

760ca5dunexpected change of behaviour in MZV

comment:3 Changed 2 years ago by chapoton

Cc: tscrim added

green bot, please review

comment:4 Changed 2 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 2 years ago by vbraun

Branch: u/chapoton/30904760ca5d00160564055aa2e6530094356eb0693b3
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.