#30895 closed enhancement (fixed)

Developers' guide: Update "Packaging Third-Party Code" regarding upstream_url

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: documentation Keywords:
Cc: slabbe, gh-tobiasdiez, jhpalmieri, dimpase, paulmasson Merged in:
Authors: Matthias Koeppe Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 86e048f (Commits, GitHub, GitLab) Commit: 86e048fc1ec5c2bf04f7eb46319f53b283a079fe
Dependencies: Stopgaps:

Status badges

Change History (10)

comment:1 Changed 10 months ago by mkoeppe

  • Cc paulmasson added

comment:2 Changed 10 months ago by mkoeppe

  • Branch set to u/mkoeppe/developers__guide__update__packaging_third_party_code__regarding_upstream_url

comment:3 Changed 10 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 8d07bb5e33c14635f84553f79b77a3e3964a6c5c
  • Status changed from new to needs_review

New commits:

8d07bb5src/doc/en/developer/packaging.rst: Mention upstream_url

comment:4 follow-up: Changed 10 months ago by dimpase

this is a bit off-topic:

Is there away to minimize checking of mirrors for tarballs that aren't there; if one adds an upstream_url, and starts installing this package, then it takes long time for Sage to discover that the tarball is not on mirrors, before using upstream_url.

comment:5 in reply to: ↑ 4 Changed 10 months ago by mkoeppe

Replying to dimpase:

Is there away to minimize checking of mirrors for tarballs that aren't there; if one adds an upstream_url, and starts installing this package, then it takes long time for Sage to discover that the tarball is not on mirrors, before using upstream_url.

You can edit the file upstream/mirror_list.

comment:6 Changed 10 months ago by dimpase

Can you add after

+--enable-download-from-upstream-url``.  Then Sage will fall back to
+downloading package tarballs from the ``upstream_url``.  It is then no
+longer necessary to manually download upstream tarballs.

something like

One can manually trim `upstream/mirror_list` to fewer mirrors so that the fallback
happens quicker.

comment:7 Changed 10 months ago by git

  • Commit changed from 8d07bb5e33c14635f84553f79b77a3e3964a6c5c to 86e048fc1ec5c2bf04f7eb46319f53b283a079fe

Branch pushed to git repo; I updated commit sha1. New commits:

86e048fsrc/doc/en/developer/packaging.rst: Trimming mirror list

comment:8 Changed 10 months ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

bot is green for the doc changes.

comment:9 Changed 10 months ago by mkoeppe

Thanks!

comment:10 Changed 10 months ago by vbraun

  • Branch changed from u/mkoeppe/developers__guide__update__packaging_third_party_code__regarding_upstream_url to 86e048fc1ec5c2bf04f7eb46319f53b283a079fe
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.